Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: chrome/browser/android/data_usage/data_use_ui_tab_model_unittest.cc

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/data_usage/data_use_ui_tab_model.h" 5 #include "chrome/browser/android/data_usage/data_use_ui_tab_model.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id)); 170 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(foo_tab_id));
171 data_use.request_start = 171 data_use.request_start =
172 base::TimeTicks::Now() + base::TimeDelta::FromMinutes(10); 172 base::TimeTicks::Now() + base::TimeDelta::FromMinutes(10);
173 data_use_tab_model()->GetLabelForDataUse(data_use, &got_label); 173 data_use_tab_model()->GetLabelForDataUse(data_use, &got_label);
174 EXPECT_EQ(std::string(), got_label) << i; 174 EXPECT_EQ(std::string(), got_label) << i;
175 } 175 }
176 176
177 const SessionID::id_type bar_tab_id = foo_tab_id + 1; 177 const SessionID::id_type bar_tab_id = foo_tab_id + 1;
178 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id)); 178 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id));
179 data_use_ui_tab_model()->ReportCustomTabInitialNavigation( 179 data_use_ui_tab_model()->ReportCustomTabInitialNavigation(
180 bar_tab_id, std::string(), kFooPackage); 180 bar_tab_id, kFooPackage, std::string());
181 base::RunLoop().RunUntilIdle(); 181 base::RunLoop().RunUntilIdle();
182 182
183 // |data_use_ui_tab_model| should receive callback about starting of 183 // |data_use_ui_tab_model| should receive callback about starting of
184 // tracking of data usage for |bar_tab_id|. 184 // tracking of data usage for |bar_tab_id|.
185 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id)); 185 EXPECT_TRUE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id));
186 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id)); 186 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingStarted(bar_tab_id));
187 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id)); 187 EXPECT_FALSE(data_use_ui_tab_model()->HasDataUseTrackingEnded(bar_tab_id));
188 188
189 data_use_ui_tab_model()->ReportTabClosure(bar_tab_id); 189 data_use_ui_tab_model()->ReportTabClosure(bar_tab_id);
190 base::RunLoop().RunUntilIdle(); 190 base::RunLoop().RunUntilIdle();
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 EXPECT_FALSE(data_use_ui_tab_model()->ConvertTransitionType( 331 EXPECT_FALSE(data_use_ui_tab_model()->ConvertTransitionType(
332 ui::PageTransition(ui::PAGE_TRANSITION_MANUAL_SUBFRAME), 332 ui::PageTransition(ui::PAGE_TRANSITION_MANUAL_SUBFRAME),
333 &transition_type)); 333 &transition_type));
334 EXPECT_FALSE(data_use_ui_tab_model()->ConvertTransitionType( 334 EXPECT_FALSE(data_use_ui_tab_model()->ConvertTransitionType(
335 ui::PageTransition(ui::PAGE_TRANSITION_FORM_SUBMIT), &transition_type)); 335 ui::PageTransition(ui::PAGE_TRANSITION_FORM_SUBMIT), &transition_type));
336 } 336 }
337 337
338 } // namespace android 338 } // namespace android
339 339
340 } // namespace chrome 340 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698