Miscellaneous fixes to DataUse UI

chrome/browser/android/data_usage/data_use_ui_tab_model.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_UI_TAB_MODEL_H_
 #define CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_UI_TAB_MODEL_H_
 
 #include <string>
 
 #include "base/containers/hash_tables.h"
@@ skipping 41 matching lines @@
                                SessionID::id_type tab_id) const;
 
   // Reports a tab closure for the tab with |tab_id| to the DataUseTabModel on
   // IO thread. The tab could either have been closed or evicted from the memory
   // by Android.
   void ReportTabClosure(SessionID::id_type tab_id);
 
   // Reports a custom tab navigation to the DataUseTabModel on the IO thread.
   // Includes the |tab_id|, |url|, and |package_name| for the navigation.
   void ReportCustomTabInitialNavigation(SessionID::id_type tab_id,
-                                        const std::string& url,
-                                        const std::string& package_name);
+                                        const std::string& package_name,
+                                        const std::string& url);
 
   // Returns true if data use tracking has been started for the tab with id
   // |tab_id|. Calling this function resets the state of the tab.
   bool HasDataUseTrackingStarted(SessionID::id_type tab_id);
 
   // Returns true if data use tracking has ended for the tab with id |tab_id|.
   // Calling this function resets the state of the tab.
   bool HasDataUseTrackingEnded(SessionID::id_type tab_id);
 
   // Sets the pointer to DataUseTabModel. |data_use_tab_model| is owned by the
   // caller.
   void SetDataUseTabModel(DataUseTabModel* data_use_tab_model);
 
+  // Returns true if the tab with id |tab_id| is currently tracked, and
+  // starting the navigation to |url| with transition type |page_transition|
+  // would end tracking of data use.

[megjablon, 2015/12/29 00:38:24]

Add "Should only be called before the navigation starts."

[tbansal1, 2015/12/29 01:18:41]

Done.

+  bool WouldDataUseTrackingEnd(const std::string& url,
+                               int page_transition,
+                               SessionID::id_type tab_id) const;
+
+  // Notifies that user clicked "Continue" when the dialog box with data use
+  // warning was shown. Includes the |tab_id| on which the warning was shown.
+  // When the user clicks "Continue", additional UI warnings about exiting data
+  // use tracking are not shown to the user.
+  void UserClickedContinueOnDialogBox(SessionID::id_type tab_id);
+
   base::WeakPtr<DataUseUITabModel> GetWeakPtr();
 
  private:
   FRIEND_TEST_ALL_PREFIXES(DataUseUITabModelTest, ConvertTransitionType);
   FRIEND_TEST_ALL_PREFIXES(DataUseUITabModelTest, EntranceExitState);
+  FRIEND_TEST_ALL_PREFIXES(DataUseUITabModelTest,
+                           EntranceExitStateWithDialogBox);
   FRIEND_TEST_ALL_PREFIXES(DataUseUITabModelTest, ReportTabEventsTest);
 
   // DataUseTrackingEvent indicates the state of a tab.
   enum DataUseTrackingEvent {
     // Indicates that data use tracking has started.
     DATA_USE_TRACKING_STARTED,
 
     // Indicates that data use tracking has ended.
     DATA_USE_TRACKING_ENDED,
+
+    // Indicates that user clicked "Continue" when the dialog box was shown.
+    DATA_USE_CONTINUE_CLICKED,
   };
 
   typedef base::hash_map<SessionID::id_type, DataUseTrackingEvent> TabEvents;
 
   // DataUseTabModel::TabDataUseObserver implementation:
   void NotifyTrackingStarting(SessionID::id_type tab_id) override;
   void NotifyTrackingEnding(SessionID::id_type tab_id) override;
 
   // Creates |event| for tab with id |tab_id| and value |event|, if there is no
   // existing entry for |tab_id|, and returns true. Otherwise, returns false
@@ skipping 25 matching lines @@
   base::WeakPtrFactory<DataUseUITabModel> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DataUseUITabModel);
 };
 
 }  // namespace android
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_ANDROID_DATA_USAGE_DATA_USE_UI_TAB_MODEL_H_