Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1539763003: MIPS64: Fix trunc_l_[s,d] in simulator. (Closed)

Created:
5 years ago by akos.palfi.imgtec
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix trunc_l_[s,d] in simulator. The trunc_l_[s,d] instructions incorrectly returns success when the input is INT64_MAX. TEST=test-run-machops/RunTryTruncateFloat32ToInt64WithCheck,test-run-machops/RunTryTruncateFloat64ToInt64WithCheck BUG= Committed: https://crrev.com/53a0cc846661c65b4b1711f67642677d8da69119 Cr-Commit-Position: refs/heads/master@{#32968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/mips/simulator-mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
akos.palfi.imgtec
5 years ago (2015-12-18 12:57:01 UTC) #5
akos.palfi.imgtec
5 years ago (2015-12-18 12:57:01 UTC) #6
balazs.kilvady
LGTM
5 years ago (2015-12-18 12:58:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539763003/1
5 years ago (2015-12-18 12:58:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 13:19:35 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53a0cc846661c65b4b1711f67642677d8da69119 Cr-Commit-Position: refs/heads/master@{#32968}
5 years ago (2015-12-18 13:20:29 UTC) #13
akos.palfi.imgtec
5 years ago (2015-12-21 16:20:32 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1543613002/ by akos.palfi@imgtec.com.

The reason for reverting is: Causes failures in r6 mode..

Powered by Google App Engine
This is Rietveld 408576698