Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1539693003: [Blob] Fix for resetting reader. (Closed)

Created:
5 years ago by dmurph
Modified:
5 years ago
Reviewers:
michaeln
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Blob] Fix for resetting reader. TBR=michaeln,mmenke BUG=567692 Committed-First-Time: https://crrev.com/ebf7a6b19a7a468195a5606fbd2bbd6d07a26ea2 Cr-Commit-Position-First-Time: refs/heads/master@{#365177} Review URL: https://codereview.chromium.org/1513783005 Cr-Commit-Position: refs/heads/master@{#365316} (cherry picked from commit f01c1228c9cca9b4078443438dfa868f7b972ac2) Conflicts: content/browser/loader/upload_data_stream_builder.cc Committed: https://chromium.googlesource.com/chromium/src/+/0ee4d4457a902c929814b17eab584fd2c94794d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -9 lines) Patch
M content/browser/loader/upload_data_stream_builder.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M storage/browser/blob/upload_blob_element_reader.h View 4 chunks +12 lines, -3 lines 0 comments Download
M storage/browser/blob/upload_blob_element_reader.cc View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539693003/1
5 years ago (2015-12-17 22:43:38 UTC) #2
commit-bot: I haz the power
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in ...
5 years ago (2015-12-17 22:43:40 UTC) #4
dmurph
5 years ago (2015-12-17 23:00:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ee4d4457a902c929814b17eab584fd2c94794d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698