Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1539693002: move DartCompletionSorter to dart specific contributor (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

move DartCompletionSorter to dart specific contributor consolidate common test code remove duplicate test R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fbaba5637550e5e2d79cd9295e2be0a2e05b4cdd

Patch Set 1 #

Patch Set 2 : sort imports #

Total comments: 1

Patch Set 3 : merge #

Messages

Total messages: 5 (2 generated)
danrubel
https://codereview.chromium.org/1539693002/diff/20001/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart File pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart (left): https://codereview.chromium.org/1539693002/diff/20001/pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart#oldcode64 pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart:64: fail_mixin_ordering() async { Duplicate test. Fixed and moved elsewhere ...
5 years ago (2015-12-17 22:25:12 UTC) #2
scheglov
LGTM
5 years ago (2015-12-17 22:51:34 UTC) #3
danrubel
5 years ago (2015-12-17 22:54:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
fbaba5637550e5e2d79cd9295e2be0a2e05b4cdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698