mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl - Issue 1539673003: Generate Mojom Types in Dart (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl

Issue 1539673003: Generate Mojom Types in Dart (Take 2) (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Move and Standardize Mojom Type Functions Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl ('K') | « mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_dart_generator.py » ('j') | mojo/public/tools/bindings/generators/mojom_dart_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl b/mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl

index 349100007993b2b0f03702eff9866ebe0dfa3c93..40fb7bcfe4a00333feae5506701d61b4192c992a 100644

--- a/mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl

@@ -1,6 +1,7 @@

{#--- Begin #}

{%- import "encoding_macros.tmpl" as encoding_macros %}

+{% import "mojom_type_macros.tmpl" as mojom_type_macros %}

{%- macro enum_def(union) %}

enum {{union|name}}Tag {

@@ -108,7 +109,9 @@ class {{union|name}} extends bindings.Union {

{%- endmacro %}

-{%- macro union_def(union) %}

+{%- macro union_def(union, typepkg, package) %}

zra 2016/01/27 18:15:12 I wonder if extra newlines like this one might be

alexfandrianto 2016/01/28 03:45:13 Done.

+{{ mojom_type_macros.writeMojomTypeDef(union, typepkg, package) }}

{%- endmacro %}