Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: mojo/dart/embedder/embedder.gni

Issue 1539673003: Generate Mojom Types in Dart (Take 2) (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Move and Standardize Mojom Type Functions Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/embedder/embedder.gni
diff --git a/mojo/dart/embedder/embedder.gni b/mojo/dart/embedder/embedder.gni
index dd9dcdfb6e942109643d606b19ddefaffecb6fcc..73fb1805c9f4f81e28754e156b79c9380d029355 100644
--- a/mojo/dart/embedder/embedder.gni
+++ b/mojo/dart/embedder/embedder.gni
@@ -23,12 +23,17 @@ template("dart_embedder_package") {
"//mojo/dart/embedder/tools/dart_list_generated_bindings.py")
root_prefix = rebase_path("//")
source_directory = rebase_path(package_path)
- generated_bindings = exec_script(list_generated_bindings_script,
- [
- source_directory,
- root_prefix,
- ],
- "list lines")
+
+ arguments = [
+ source_directory,
+ root_prefix,
+ ]
+ if (defined(invoker.is_bindings_types) && invoker.is_bindings_types) {
+ arguments += [ "--bindings-types" ]
+ }
+
+ generated_bindings =
+ exec_script(list_generated_bindings_script, arguments, "list lines")
sources = rebase_path(generated_bindings, ".", root_gen_dir)
outputs = [
"$root_gen_dir/dart_embedder_packages/$destination/{{source_file_part}}",

Powered by Google App Engine
This is Rietveld 408576698