mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart - Issue 1539673003: Generate Mojom Types in Dart (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart

Issue 1539673003: Generate Mojom Types in Dart (Take 2) (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: All Short Names use unsafe GetElementForName Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/packages/mojo_services/lib/mojo/view_manager.mojom.dart ('k') | mojo/dart/packages/mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart » ('j') | mojo/public/tools/bindings/generators/mojom_dart_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart

diff --git a/mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart b/mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart

index 7591fbaa3f41127bf8493f0587b8e4504dae9510..00d6bbcd203b1144ef1637beded8ddef7a9aa008 100644

--- a/mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart

+++ b/mojo/dart/packages/mojo_services/lib/mojo/view_manager_constants.mojom.dart

@@ -8,6 +8,7 @@ import 'dart:async';

import 'package:mojo/bindings.dart' as bindings;

import 'package:mojo/core.dart' as core;

+import 'package:mojo/mojo/bindings/types/mojom_types.mojom.dart' as mojom_types;

class OrderDirection extends bindings.MojoEnum {

static const OrderDirection above = const OrderDirection._(1);

@@ -53,6 +54,8 @@ class OrderDirection extends bindings.MojoEnum {

return 'OrderDirection.above';

case below:

return 'OrderDirection.below';

+ default:

+ return null;

}

@@ -61,3 +64,8 @@ class OrderDirection extends bindings.MojoEnum {