Generate Mojom Types in Dart (Take 2)

mojo/dart/packages/mojom/lib/src/generate.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /// This library generates Mojo bindings for a Dart package.
 
 library generate;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:developer' as dev;
 import 'dart:io';
 
 import 'package:mojom/src/utils.dart';
 import 'package:path/path.dart' as path;
 
 part 'mojom_finder.dart';
 
+const String mojoTestPackage = '_mojo_for_test_only';
+
 class MojomGenerator {
   static dev.Counter _genMs;
   final bool _errorOnDuplicate;
   final bool _dryRun;
   final bool _force;
   final Directory _mojoSdk;
 
   Map<String, String> _duplicateDetection;
   int _generationMs;
 
@@ skipping 125 matching lines @@
 
     final script = path.join(
         _mojoSdk.path, 'tools', 'bindings', 'mojom_bindings_generator.py');
     final sdkInc = path.normalize(path.join(_mojoSdk.path, '..', '..'));
     final outputDir = await Directory.systemTemp.createTemp();
     try {
       final output = outputDir.path;
 
       final servicesPath = _sniffForMojoServicesInclude(mojom.path);
 
+      final generateTypeInfoFlag = packageName == mojoTestPackage ?

[zra, 2016/01/27 18:15:12]

Please add a TODO and file a bug to remove this hack. Whether to generate type
info should be a flag to the command.

[alexfandrianto, 2016/01/28 03:45:12]

Done.

+        '--generate-type-info' : '--no-generate-type-info';
+
       final arguments = [
         '--use_bundled_pylibs',
         '-g',
         'dart',
         '-o',
         output,
         '-I',
         sdkInc,
         '-I',
         importDir.path,
-        '--no-gen-imports'
+        '--no-gen-imports',
+        generateTypeInfoFlag
       ];
       if (servicesPath != null) {
         arguments.add('-I');
         arguments.add(servicesPath);
       }
       arguments.add(mojom.path);
 
       log.info('Generating $mojom');
       log.info('$script ${arguments.join(" ")}');
       log.info('dryRun = $_dryRun');
       if (!_dryRun) {
         final result = await _runBindingsGeneration(script, arguments);
         if (result.exitCode != 0) {
           log.info("bindings generation result = ${result.exitCode}");
           await outputDir.delete(recursive: true);
           throw new GenerationError("$script failed:\n"
               "code: ${result.exitCode}\n"
               "stderr: ${result.stderr}\n"
               "stdout: ${result.stdout}");
         } else {
           log.info("bindings generation result = 0");
         }
 
         // Generated .mojom.dart is under $output/dart-gen/$PACKAGE/lib/$X
         // Move $X to |destination|/lib/$X.
-        // Throw an exception if $PACKGE != [packageName].
+        // Throw an exception if $PACKAGE != [packageName].
         final generatedDirName = path.join(output, 'dart-gen');
         final generatedDir = new Directory(generatedDirName);
         log.info("generatedDir= $generatedDir");
         assert(await generatedDir.exists());
         await for (var genpack in generatedDir.list()) {
           if (genpack is! Directory) continue;
           log.info("genpack = $genpack");
           var libDir = new Directory(path.join(genpack.path, 'lib'));
           var name = path.relative(genpack.path, from: generatedDirName);
           log.info("Found generated lib dir: $libDir");
@@ skipping 226 matching lines @@
             '\t$dart $packRoot $scriptPath single -m $mojoSdk -r $root '
             '-p $packagePath $skips');
         _errors++;
         return;
       }
     }
   }
 
   bool _shouldSkip(File f) => containsPrefix(f.path, _skip);
 }