Generate Mojom Types in Dart (Take 2)

mojo/dart/packages/mojo/lib/src/proxy.dart

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 part of bindings;
 
 class ProxyError {
   final String message;
   ProxyError(this.message);
   String toString() => "ProxyError: $message";
@@ skipping 17 matching lines @@
   void handleResponse(ServiceMessage reader);
 
   /// If there is an error in using this proxy, this future completes with
   /// a ProxyError.
   Future get errorFuture => _errorCompleter.future;
 
   /// Version of this interface that the remote side supports. Updated when a
   /// call to [queryVersion] or [requireVersion] is made.
   int get version => _version;
 
+  /// Returns a service description, which exposes the mojom type information
+  /// of the service being proxied. This type information can be forwarded to
+  /// other Mojo applications and can be used to implement a generic client.
+  /// Note: In some implementations, the ServiceDescription returned will not
+  /// provide type information. Methods called may return null or an error.

[zra, 2016/01/27 18:15:12]

It's unclear if you mean the `description` getter could return an error, or if a
method it describes could return an error.

I'd recommend cutting this comment down a bit. I think all that's needed is the
first sentence, and a warning that it might be null.

[alexfandrianto, 2016/01/28 03:45:12]

Done.

+  service_describer.ServiceDescription get description => null;
+
   void handleRead() {
     var result = endpoint.queryAndRead();
     if ((result.data == null) || (result.dataLength == 0)) {
       proxyError("Read from message pipe endpoint failed");
       return;
     }
     try {
       var message = new ServiceMessage.fromMessage(new Message(result.data,
           result.handles, result.dataLength, result.handlesLength));
       _pendingCount--;
@@ skipping 197 matching lines @@
 
 /// Generated Proxy classes have a factory Proxy.connectToService which takes
 /// a ServiceConnector, a url, and optionally a service name and returns a
 /// bound Proxy. For example, every class extending the Application base class
 /// in package:mojo/application.dart inherits and implementation of the
 /// ServiceConnector interface.
 abstract class ServiceConnector {
   /// Connects [proxy] to the service called [serviceName] that lives at [url].
   void connectToService(String url, ProxyBase proxy, [String serviceName]);
 }