Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1539653002: Revert of Supervised user web restrictions content provider (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
CC:
Bernhard Bauer, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Supervised user web restrictions content provider (patchset #12 id:220001 of https://codereview.chromium.org/1452603002/ ) Reason for revert: The new test is failing on CQ BUG=570768 Original issue's description: > Supervised user web restrictions content provider > > The web restrictions content provider lets other apps query > web restrictions. In particular it lets apps using WebView > query Chrome's supervised user web restrictions. > > BUG=569879 > > Committed: https://crrev.com/d501894251559fe547bda9381bdeb98d229f6e7c > Cr-Commit-Position: refs/heads/master@{#365834} TBR=jochen@chromium.org,bauerb@chromium.org,knn@chromium.org,aberent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569879 Committed: https://crrev.com/2187ddb9a33c00b8af78ab7b4562af90109fe1f8 Cr-Commit-Position: refs/heads/master@{#365870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1120 lines) Patch
M chrome/android/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java View 3 chunks +0 lines, -7 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java View 1 chunk +0 lines, -180 lines 0 comments Download
M chrome/android/javatests/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderTest.java View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java View 1 chunk +0 lines, -230 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/supervised_user/supervised_user_content_provider_android.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/supervised_user/supervised_user_content_provider_android.cc View 1 chunk +0 lines, -141 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 3 chunks +11 lines, -19 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -3 lines 0 comments Download
D components/web_restriction.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D components/web_restriction/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D components/web_restriction/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/web_restriction/java/src/org/chromium/components/webrestriction/WebRestrictionsContentProvider.java View 1 chunk +0 lines, -178 lines 0 comments Download
D components/web_restriction/junit/src/org/chromium/components/webrestriction/WebRestrictionsContentProviderTest.java View 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
Created Revert of Supervised user web restrictions content provider
5 years ago (2015-12-17 19:57:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539653002/1
5 years ago (2015-12-17 19:59:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539653002/1
5 years ago (2015-12-17 20:04:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 20:10:12 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-17 20:11:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2187ddb9a33c00b8af78ab7b4562af90109fe1f8
Cr-Commit-Position: refs/heads/master@{#365870}

Powered by Google App Engine
This is Rietveld 408576698