Make InfoBarControlLayouts more aesthetically pleasing

chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.infobar;
 
 import android.content.Context;
 import android.content.res.Resources;
 import android.support.v7.widget.SwitchCompat;
 import android.text.method.LinkMovementMethod;
@@ skipping 74 matching lines @@
 
         int fullWidth = MeasureSpec.getMode(widthMeasureSpec) == MeasureSpec.UNSPECIFIED
                 ? mMaxInfoBarWidth : MeasureSpec.getSize(widthMeasureSpec);
         int columnWidth = Math.max(0, (fullWidth - mMarginBetweenColumns) / 2);
 
         int atMostFullWidthSpec = MeasureSpec.makeMeasureSpec(fullWidth, MeasureSpec.AT_MOST);
         int exactlyFullWidthSpec = MeasureSpec.makeMeasureSpec(fullWidth, MeasureSpec.EXACTLY);
         int exactlyColumnWidthSpec = MeasureSpec.makeMeasureSpec(columnWidth, MeasureSpec.EXACTLY);
         int unspecifiedSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);
 
-        // Measure all children, assuming they all have to fit within the width of the layout.
-        // Height is unconstrained.
+        // Figure out how many columns each child requires.
         for (int i = 0; i < getChildCount(); i++) {
             View child = getChildAt(i);
             measureChild(child, atMostFullWidthSpec, unspecifiedSpec);
 
             if (child.getMeasuredWidth() <= columnWidth
                     && !getControlLayoutParams(child).mMustBeFullWidth) {
-                // Stretch out the control to take up a column width.
                 getControlLayoutParams(child).columnsRequired = 1;
-                measureChild(child, exactlyColumnWidthSpec, unspecifiedSpec);
             } else {
-                // Stretch out the control to take up the full width.
                 getControlLayoutParams(child).columnsRequired = 2;
-                measureChild(child, exactlyFullWidthSpec, unspecifiedSpec);
             }
         }
 
         // Pack all the children as tightly into rows as possible without changing their ordering.
+        // Stretch out column-width controls if either it is the last control or the next one is
+        // a full-width control.
+        for (int i = 0; i < getChildCount(); i++) {
+            ControlLayoutParams lp = getControlLayoutParams(getChildAt(i));
+
+            if (i == getChildCount() - 1) {
+                lp.columnsRequired = 2;
+            } else {
+                ControlLayoutParams nextLp = getControlLayoutParams(getChildAt(i + 1));
+                if (lp.columnsRequired + nextLp.columnsRequired > 2) {
+                    // This control is too big to place with the next child.
+                    lp.columnsRequired = 2;
+                } else {
+                    // This and the next control fit on the same line.  Skip placing the next child.
+                    i++;
+                }
+            }
+        }
+
+        // Measure all children, assuming they all have to fit within the width of the layout.
+        // Height is unconstrained.
+        for (int i = 0; i < getChildCount(); i++) {
+            View child = getChildAt(i);
+            ControlLayoutParams lp = getControlLayoutParams(child);
+            int spec = lp.columnsRequired == 1 ? exactlyColumnWidthSpec : exactlyFullWidthSpec;
+            measureChild(child, spec, unspecifiedSpec);
+        }
+
+        // Pack all the children as tightly into rows as possible without changing their ordering.
         int layoutHeight = 0;
         int nextChildStart = 0;
         int nextChildTop = 0;
         int currentRowHeight = 0;
         int columnsAvailable = 2;
         for (int i = 0; i < getChildCount(); i++) {
             View child = getChildAt(i);
             ControlLayoutParams lp = getControlLayoutParams(child);
 
             // If there isn't enough room left for the control, move to the next row.
@@ skipping 142 matching lines @@
 
     /**
      * @return The {@link ControlLayoutParams} for the given child.
      */
     @VisibleForTesting
     static ControlLayoutParams getControlLayoutParams(View child) {
         return (ControlLayoutParams) child.getLayoutParams();
     }
 
 }