Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1539623002: Compute values of elements a unit constant expressions depend on. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Paul Berry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute values of elements a unit constant expressions depend on. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/83c1106ffed31a61b7320932d84e8aa17a539d1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -23 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +44 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 10 chunks +44 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 4 chunks +55 lines, -8 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/tasks.dot View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-17 19:35:23 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-17 19:45:37 UTC) #2
scheglov
5 years ago (2015-12-17 19:47:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83c1106ffed31a61b7320932d84e8aa17a539d1e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698