DescriptionRevert of Update the static_cast style check to check for DEFINE_TYPE_CASTS patterns as well. (https://codereview.chromium.org/145033013/)
Reason for revert:
The patch will be breaking the style check on the patch since the regex compiled _RE_GENERAL_MACRO_PATTERN_STRING & _RE_GENERAL_MACRO_PATTERN_STRING are not correct.
The regex (mentioned above) needs to be set properly. Will be uploading new patch with correct regex.
Original issue's description:
> Update the static_cast style check to check for DEFINE_TYPE_CASTS patterns as well.
>
> Existing implementation of check-webkit-style warns the user if he uses static_cast<>
> in the code. This is behind runtime/casting filter which needs to be enabled specifically.
>
> As part of 309516, all the toFoo() definitions have been replaced with DEFINE_*_TYPE_CASTS
> macro, which defines the toFoo functions at compile time. This patch updates the check to
> include even the macro pattern to identify whether existing toFoo exists or user needs to
> define the toFoo convienience function (through macro).
>
> Since all existing usage of static_cast<Foo*> has been replaced with toFoo() calls,
> now we are throwing an error if user uses static_cast<> inspite of presence of toFoo().
> If toFoo doesn't exist, we still retain a warning behind runtime/casting filter.
>
> BUG=309516
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166491
TBR=dpranke@chromium.org,tkent@chromium.org,inferno@chromium.org,aarya@google.com,sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=309516
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166501
Patch Set 1 #
Created: 6 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 10 (0 generated)
|