Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153953003: [Android] Remove unused RWHVA touch handler notification (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Remove unused RWHVA touch handler notification The RenderWidgetHostViewAndroid::HasTouchEventHandlers notification is no longer used, remove accordingly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248900

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : More removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jdduke (slow)
joi@: PTAL. Thanks.
6 years, 10 months ago (2014-02-04 16:29:47 UTC) #1
Jói
LGTM
6 years, 10 months ago (2014-02-04 17:15:45 UTC) #2
Jói
On 2014/02/04 17:15:45, Jói wrote: > LGTM Note that I'm an owner for content/port but ...
6 years, 10 months ago (2014-02-04 17:16:17 UTC) #3
jdduke (slow)
aelias@: Review for content/browser/renderer_host? Thanks.
6 years, 10 months ago (2014-02-04 18:01:41 UTC) #4
aelias_OOO_until_Jul13
lgtm
6 years, 10 months ago (2014-02-04 18:18:28 UTC) #5
jdduke (slow)
sky@: Review for content/browser/frame_host and content/test? Thanks.
6 years, 10 months ago (2014-02-04 23:05:42 UTC) #6
sky
LGTM
6 years, 10 months ago (2014-02-05 01:00:44 UTC) #7
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-05 01:09:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/153953003/160001
6 years, 10 months ago (2014-02-05 03:52:55 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 07:25:05 UTC) #10
Message was sent while issue was closed. 
Change committed as 248900

Powered by Google App Engine
This is Rietveld 408576698