Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 15395002: Added posix and windows runner scripts for download_from_google_storage.py (Closed)

Created:
7 years, 7 months ago by Ryan Tseng
Modified:
7 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ukai
Visibility:
Public.

Description

Added posix and windows runner scripts for download_from_google_storage.py Windows bots are having trouble calling download_from_google_storage.py from the DEPS hooks. This should allow it to be called as just "download_from_google_storage". BUG= R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200939

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A + download_from_google_storage View 1 chunk +1 line, -1 line 0 comments Download
A + download_from_google_storage.bat View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Tseng
From what I can tell, Goma canary windows bots are rather stubborn about calling "download_from_google_storage.py" ...
7 years, 7 months ago (2013-05-18 01:16:39 UTC) #1
M-A Ruel
On 2013/05/18 01:16:39, Ryan T. wrote: > From what I can tell, Goma canary windows ...
7 years, 7 months ago (2013-05-18 01:18:30 UTC) #2
Ryan Tseng
The main issue afaik is that when you call "python some_script.py", windows doesn't look in ...
7 years, 7 months ago (2013-05-18 01:21:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/15395002/3001
7 years, 7 months ago (2013-05-18 01:21:34 UTC) #4
commit-bot: I haz the power
Failed to apply patch for depot_tools/download_from_google_storage.bat: While running patch -p1 --forward --force --no-backup-if-mismatch; A depot_tools/download_from_google_storage.bat ...
7 years, 7 months ago (2013-05-18 01:21:35 UTC) #5
Ryan Tseng
Committed patchset #2 manually as r200939.
7 years, 7 months ago (2013-05-18 01:23:35 UTC) #6
M-A Ruel
7 years, 7 months ago (2013-05-18 01:33:44 UTC) #7
Message was sent while issue was closed.
On 2013/05/18 01:21:21, Ryan T. wrote:
> The main issue afaik is that when you call "python some_script.py", windows
> doesn't look in PATH or PYTHON_PATH for some_script.py.

Yeah, that's why I thought I (?) had coded so that CMDrunhooks replace 'python'
for sys.executable before running the hooks.

Powered by Google App Engine
This is Rietveld 408576698