Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: src/runtime/runtime-observe.cc

Issue 1539483002: [debugger] simplify stepping logic. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-observe.cc
diff --git a/src/runtime/runtime-observe.cc b/src/runtime/runtime-observe.cc
index df0b2a330ca96bd0b4d1d9af2712a1cc877ba150..b3c6ff11797ae4bc236487c36ab45c7847f8d0c9 100644
--- a/src/runtime/runtime-observe.cc
+++ b/src/runtime/runtime-observe.cc
@@ -65,16 +65,8 @@ RUNTIME_FUNCTION(Runtime_DeliverObservationChangeRecords) {
catcher.SetVerbose(true);
Handle<Object> argv[] = {argument};
- // Allow stepping into the observer callback.
- Debug* debug = isolate->debug();
- if (debug->is_active() && debug->IsStepping() &&
- debug->last_step_action() == StepIn) {
- // Previous StepIn may have activated a StepOut if it was at the frame exit.
- // In this case to be able to step into the callback again, we need to clear
- // the step out first.
- debug->ClearStepOut();
- debug->FloodWithOneShot(callback);
- }
+ // If we are in step-in mode, flood the handler.
+ isolate->debug()->EnableStepIn();
USE(Execution::Call(isolate, callback, isolate->factory()->undefined_value(),
arraysize(argv), argv));
« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698