Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153943002: Eliminate BrowserThread usage from PasswordStoreDefault. (Closed)

Created:
6 years, 10 months ago by Patrick Dubroy
Modified:
6 years, 10 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, blundell, vabr (Chromium), stuartmorgan
Visibility:
Public.

Description

Eliminate BrowserThread usage from PasswordStoreDefault. As part of componentizing the password manager, we need to remove all references to content/ from PasswordStoreDefault. Depends on https://codereview.chromium.org/152683002/. BUG=335147 R=gcasto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248964

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/password_manager/password_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_default.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Patrick Dubroy
Garrett, PTAL. blundell and vabr: FYI.
6 years, 10 months ago (2014-02-04 16:00:01 UTC) #1
Garrett Casto
lgtm
6 years, 10 months ago (2014-02-04 16:47:53 UTC) #2
Patrick Dubroy
The CQ bit was checked by dubroy@chromium.org
6 years, 10 months ago (2014-02-04 17:08:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/153943002/50001
6 years, 10 months ago (2014-02-04 17:09:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:46:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223388
6 years, 10 months ago (2014-02-04 17:46:43 UTC) #6
Patrick Dubroy
The CQ bit was checked by dubroy@chromium.org
6 years, 10 months ago (2014-02-05 09:32:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/153943002/400001
6 years, 10 months ago (2014-02-05 09:35:39 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 11:09:46 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45070
6 years, 10 months ago (2014-02-05 11:09:47 UTC) #10
Patrick Dubroy
Committed patchset #3 manually as r248964 (presubmit successful).
6 years, 10 months ago (2014-02-05 11:10:59 UTC) #11
Patrick Dubroy
6 years, 10 months ago (2014-02-05 18:46:23 UTC) #12
Message was sent while issue was closed. 
+stuartmorgan FYI

Powered by Google App Engine
This is Rietveld 408576698