Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1539423002: Revert of Switch to standard integer types in sandbox/. (Closed)

Created:
5 years ago by Pete Williamson
Modified:
5 years ago
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch to standard integer types in sandbox/. (patchset #3 id:40001 of https://codereview.chromium.org/1538283002/ ) Reason for revert: This appears to be causing a compile failure (macros.h omitted) Original issue's description: > Switch to standard integer types in sandbox/. > > BUG=138542 > TBR=cpu@chromium.org > > Committed: https://crrev.com/b5032dd2fd694a9bd7a9e96ad8fefcaf29c24c9e > Cr-Commit-Position: refs/heads/master@{#366413} TBR=cpu@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=138542 Committed: https://crrev.com/61731d3ff51877ddb5f67aa3b937d5011a348d17 Cr-Commit-Position: refs/heads/master@{#366428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -756 lines) Patch
M content/common/sandbox_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/codegen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/codegen_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/cons.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/dump_bpf.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/syscall_set.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/syscall_set_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/test_trap_registry.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/test_trap_registry.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/verifier.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/linux/integration_tests/namespace_unix_domain_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/integration_tests/seccomp_broker_process_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/namespace_sandbox.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/namespace_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/thread_helpers_unittests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/services/yama.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/suid/client/setuid_sandbox_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/suid/common/suid_unsafe_environment_variables.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/suid/process_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/suid/process_util_linux.c View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/suid/sandbox.c View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_client.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_file_permission.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_policy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_policy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_process_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/system_headers/arm64_linux_ucontext.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/system_headers/arm_linux_ucontext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/system_headers/i386_linux_ucontext.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/linux/system_headers/linux_signal.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/system_headers/mips_linux_ucontext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/system_headers/x86_64_linux_ucontext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/tests/scoped_temporary_file_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/tests/unit_tests.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/mac/bootstrap_sandbox.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/bootstrap_sandbox.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/mac/launchd_interception_server.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/mac/mach_message_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/mach_message_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/os_compatibility.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/os_compatibility.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/mac/pre_exec_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/mac/pre_exec_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/xpc_message_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/xpc_message_server_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/mac/xpc_stubs_header.fragment View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/sandbox_poc/main_ui_window.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/sandbox_poc/main_ui_window.cc View 2 chunks +1 line, -3 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/Wow64.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/Wow64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/app_container.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/app_container.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/broker_services.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/broker_services.cc View 2 chunks +1 line, -2 lines 0 comments Download
M sandbox/win/src/crosscall_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/win/src/crosscall_params.h View 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/win/src/crosscall_server.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/crosscall_server.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M sandbox/win/src/eat_resolver.h View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/eat_resolver.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/filesystem_dispatcher.h View 3 chunks +15 lines, -17 lines 0 comments Download
M sandbox/win/src/filesystem_dispatcher.cc View 11 chunks +20 lines, -22 lines 0 comments Download
M sandbox/win/src/filesystem_interception.cc View 8 chunks +15 lines, -17 lines 0 comments Download
M sandbox/win/src/filesystem_policy.h View 6 chunks +19 lines, -20 lines 0 comments Download
M sandbox/win/src/filesystem_policy.cc View 7 chunks +26 lines, -31 lines 0 comments Download
M sandbox/win/src/handle_closer.h View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/handle_closer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/handle_closer_agent.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/handle_closer_agent.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/handle_closer_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/handle_dispatcher.h View 2 chunks +4 lines, -6 lines 0 comments Download
M sandbox/win/src/handle_dispatcher.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M sandbox/win/src/handle_policy.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/interception.h View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/interception.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/interception_agent.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/interception_agent.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M sandbox/win/src/interception_internal.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/interception_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M sandbox/win/src/internal_types.h View 2 chunks +5 lines, -5 lines 0 comments Download
M sandbox/win/src/ipc_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/job.h View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/job.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/named_pipe_dispatcher.h View 2 chunks +7 lines, -9 lines 0 comments Download
M sandbox/win/src/named_pipe_dispatcher.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M sandbox/win/src/named_pipe_policy.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/nt_internals.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/policy_broker.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/policy_engine_opcodes.h View 7 chunks +37 lines, -39 lines 0 comments Download
M sandbox/win/src/policy_engine_opcodes.cc View 13 chunks +31 lines, -32 lines 0 comments Download
M sandbox/win/src/policy_engine_params.h View 3 chunks +6 lines, -6 lines 0 comments Download
M sandbox/win/src/policy_engine_processor.h View 3 chunks +7 lines, -10 lines 0 comments Download
M sandbox/win/src/policy_engine_processor.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M sandbox/win/src/policy_engine_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M sandbox/win/src/policy_low_level.h View 4 chunks +9 lines, -18 lines 0 comments Download
M sandbox/win/src/policy_low_level.cc View 8 chunks +19 lines, -23 lines 0 comments Download
M sandbox/win/src/policy_low_level_unittest.cc View 10 chunks +17 lines, -20 lines 0 comments Download
M sandbox/win/src/policy_opcodes_unittest.cc View 5 chunks +9 lines, -12 lines 0 comments Download
M sandbox/win/src/policy_target.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/process_mitigations.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/process_mitigations.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/process_mitigations_win32k_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/process_mitigations_win32k_interception.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/process_mitigations_win32k_policy.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/process_thread_dispatcher.h View 2 chunks +6 lines, -12 lines 0 comments Download
M sandbox/win/src/process_thread_dispatcher.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M sandbox/win/src/process_thread_interception.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M sandbox/win/src/process_thread_policy.h View 4 chunks +8 lines, -9 lines 0 comments Download
M sandbox/win/src/process_thread_policy.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M sandbox/win/src/registry_dispatcher.h View 2 chunks +7 lines, -9 lines 0 comments Download
M sandbox/win/src/registry_dispatcher.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M sandbox/win/src/registry_interception.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M sandbox/win/src/registry_policy.h View 3 chunks +13 lines, -14 lines 0 comments Download
M sandbox/win/src/registry_policy.cc View 5 chunks +11 lines, -13 lines 0 comments Download
M sandbox/win/src/resolver.h View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/resolver.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/resolver_32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/resolver_64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/restricted_token.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/restricted_token.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/sandbox.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/sandbox_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/sandbox_nt_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/sandbox_nt_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/win/src/sandbox_policy.h View 2 chunks +2 lines, -5 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 3 chunks +3 lines, -5 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M sandbox/win/src/sandbox_rand.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/sandbox_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/win/src/security_level.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/src/service_resolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/service_resolver_32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/service_resolver_64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/service_resolver_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/sharedmem_ipc_client.h View 2 chunks +1 line, -4 lines 0 comments Download
M sandbox/win/src/sharedmem_ipc_client.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M sandbox/win/src/sharedmem_ipc_server.h View 3 chunks +3 lines, -5 lines 0 comments Download
M sandbox/win/src/sharedmem_ipc_server.cc View 6 chunks +11 lines, -15 lines 0 comments Download
M sandbox/win/src/sidestep/preamble_patcher_with_stub.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/sidestep_resolver.h View 1 chunk +1 line, -3 lines 0 comments Download
M sandbox/win/src/sidestep_resolver.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/sync_dispatcher.h View 2 chunks +6 lines, -8 lines 0 comments Download
M sandbox/win/src/sync_dispatcher.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M sandbox/win/src/sync_interception.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M sandbox/win/src/sync_policy.h View 2 chunks +8 lines, -9 lines 0 comments Download
M sandbox/win/src/sync_policy.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M sandbox/win/src/target_process.h View 2 chunks +3 lines, -7 lines 0 comments Download
M sandbox/win/src/target_process.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M sandbox/win/src/target_services.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/target_services.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M sandbox/win/src/threadpool_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M sandbox/win/src/top_level_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/win/src/win2k_threadpool.h View 1 chunk +1 line, -4 lines 0 comments Download
M sandbox/win/src/win2k_threadpool.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/src/win_utils.h View 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/win/src/win_utils.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/tests/common/test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/tests/integration_tests/integration_tests_test.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M sandbox/win/tests/validation_tests/commands.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/tests/validation_tests/suite.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/win/wow_helper/service64_resolver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/win/wow_helper/service64_resolver.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/wow_helper/wow_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Pete Williamson
Created Revert of Switch to standard integer types in sandbox/.
5 years ago (2015-12-21 18:44:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539423002/1
5 years ago (2015-12-21 18:44:48 UTC) #2
Will Harris
I think the fix for macros.h went in too in 6dc3bf73c353723a434a55008ffd354b1b682705 unchecking, for Avi to ...
5 years ago (2015-12-21 18:45:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 18:48:44 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/61731d3ff51877ddb5f67aa3b937d5011a348d17 Cr-Commit-Position: refs/heads/master@{#366428}
5 years ago (2015-12-21 18:49:39 UTC) #8
Will Harris
5 years ago (2015-12-21 18:50:34 UTC) #9
Message was sent while issue was closed.
oop went in. well this will be interesting!

Powered by Google App Engine
This is Rietveld 408576698