Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1539403004: Roll buildtools fee7f1e849..2f04b1cc1e (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools fee7f1e849..2f04b1cc1e In order to roll GN 763cd405e2..a86c5dbbd2 (r365683:r366584) and pick up the following changes: f865ab8 Allow GN libs to be specified by path instead of by name c7ebe6d move libevent into base 9608e14 tools/gn: another round of fixes to keep bootstrap working TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Speculative win gn gen fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/BUILD.gn View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
agrieve
5 years ago (2015-12-22 18:26:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539403004/1
5 years ago (2015-12-22 18:26:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539403004/20001
5 years ago (2015-12-22 18:29:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/83576)
5 years ago (2015-12-22 19:20:05 UTC) #7
Dirk Pranke
lgtm
5 years ago (2015-12-23 03:38:44 UTC) #8
Dirk Pranke
On 2015/12/23 03:38:44, Dirk Pranke wrote: > lgtm assuming you get the code to actually ...
5 years ago (2015-12-23 03:39:09 UTC) #9
agrieve
5 years ago (2015-12-23 19:59:05 UTC) #10
On 2015/12/23 03:39:09, Dirk Pranke wrote:
> On 2015/12/23 03:38:44, Dirk Pranke wrote:
> > lgtm
> 
> assuming you get the code to actually work, of course :).

Abandoning. See: https://codereview.chromium.org/1549483003/

Powered by Google App Engine
This is Rietveld 408576698