[Android] Revise devil environment handling of host dependencies.

[Android] Revise devil environment handling of host dependencies.

BUG=

Committed: https://crrev.com/23924599e25c0115d990ab629ea8acfc55d9d6e4
Cr-Commit-Position: refs/heads/master@{#366672}

[jbudorick, 2015-12-21 18:03:57]

jbudorick@chromium.org changed reviewers:
+ mikecase@chromium.org, rnephew@chromium.org

[jbudorick, 2015-12-21 18:03:58]

The local build product logic was broken for host_forwarder + md5sum_bin_host,
and the rest of it was unnecessarily different from how telemetry handles
platform + architecture in dealing with binary dependencies.

[rnephew (Wrong account), 2015-12-21 18:23:19]

rnephew@google.com changed reviewers:
+ rnephew@google.com

[rnephew (Wrong account), 2015-12-21 18:23:19]

https://codereview.chromium.org/1539403002/diff/1/build/android/devil/devil_e...
File build/android/devil/devil_env.py (right):

https://codereview.chromium.org/1539403002/diff/1/build/android/devil/devil_e...
build/android/devil/devil_env.py:45: 'platform': 'linux_x86)64',
should that be 86_64?

https://codereview.chromium.org/1539403002/diff/1/build/android/devil_chromiu...
File build/android/devil_chromium.py (right):

https://codereview.chromium.org/1539403002/diff/1/build/android/devil_chromiu...
build/android/devil_chromium.py:19: 'arch': 'armeabi-v7a',
why are some - and some _? This might be confusing, unless there is some rule on
when to use one vs the other.

[jbudorick, 2015-12-21 19:20:36]

https://codereview.chromium.org/1539403002/diff/1/build/android/devil/devil_e...
File build/android/devil/devil_env.py (right):

https://codereview.chromium.org/1539403002/diff/1/build/android/devil/devil_e...
build/android/devil/devil_env.py:45: 'platform': 'linux_x86)64',
On 2015/12/21 18:23:19, rnephew wrote:
> should that be 86_64?

yes. fixed.

https://codereview.chromium.org/1539403002/diff/1/build/android/devil_chromiu...
File build/android/devil_chromium.py (right):

https://codereview.chromium.org/1539403002/diff/1/build/android/devil_chromiu...
build/android/devil_chromium.py:19: 'arch': 'armeabi-v7a',
On 2015/12/21 18:23:19, rnephew wrote:
> why are some - and some _? This might be confusing, unless there is some rule
on
> when to use one vs the other.

it's what the device returns for ro.product.cpu.abi.

[mikecase (-- gone --), 2015-12-22 16:49:49]

https://codereview.chromium.org/1539403002/diff/20001/build/android/devil_chr...
File build/android/devil_chromium.py (right):

https://codereview.chromium.org/1539403002/diff/20001/build/android/devil_chr...
build/android/devil_chromium.py:51: 'arch': 'x86_64',
You mentioned md5sum_host and forwarder_host were broken in some way so Im
guessing these changes are good, but previously the arch was listed as "any" and
now it is just x86_64. Is this intentional?

https://codereview.chromium.org/1539403002/diff/20001/build/android/devil_chr...
build/android/devil_chromium.py:90: 'arch': 'x86_64',
previously the arch was listed as "any" and now it is just x86_64. Is this
intentional?

[jbudorick, 2015-12-22 17:22:18]

https://codereview.chromium.org/1539403002/diff/20001/build/android/devil_chr...
File build/android/devil_chromium.py (right):

https://codereview.chromium.org/1539403002/diff/20001/build/android/devil_chr...
build/android/devil_chromium.py:51: 'arch': 'x86_64',
On 2015/12/22 16:49:49, mikecase wrote:
> You mentioned md5sum_host and forwarder_host were broken in some way so Im
> guessing these changes are good, but previously the arch was listed as "any"
and
> now it is just x86_64. Is this intentional?

Yeah, "any" was a leftover from an initial version of the devil environment. I
moved it to "host" before landing that CL. I then had moved the other host-side
binaries to be OS-specific back in https://codereview.chromium.org/1501843002/,
but even that's too generic.

[mikecase (-- gone --), 2015-12-22 17:28:56]

lgtm

[jbudorick, 2015-12-22 17:35:26]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-12-22 17:36:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539403002/20001

[commit-bot: I haz the power, 2015-12-22 17:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-22 17:58:31]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jbudorick, 2015-12-22 21:27:38]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2015-12-22 21:27:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/1539403002/#ps40001
(title: "fix empty config w/o output_directory")

[commit-bot: I haz the power, 2015-12-22 21:28:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539403002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539403002/40001

[commit-bot: I haz the power, 2015-12-22 22:36:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-22 22:37:27]

Description was changed from

==========
[Android] Revise devil environment handling of host dependencies.

BUG=
==========

to

==========
[Android] Revise devil environment handling of host dependencies.

BUG=

Committed: https://crrev.com/23924599e25c0115d990ab629ea8acfc55d9d6e4
Cr-Commit-Position: refs/heads/master@{#366672}
==========

[commit-bot: I haz the power, 2015-12-22 22:37:28]

Patchset 3 (id:??) landed as
https://crrev.com/23924599e25c0115d990ab629ea8acfc55d9d6e4
Cr-Commit-Position: refs/heads/master@{#366672}