Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: build/config/BUILD.gn

Issue 1539353002: GN(android): Default libs logic from runtime_library -> default_libs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix try job failure due to lib order Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/features.gni") 9 import("//build/config/features.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 "winmm.lib", 356 "winmm.lib",
357 "winspool.lib", 357 "winspool.lib",
358 "ws2_32.lib", 358 "ws2_32.lib",
359 359
360 # Please don't add more stuff here. We should actually be making this 360 # Please don't add more stuff here. We should actually be making this
361 # list smaller, since all common things should be covered. If you need 361 # list smaller, since all common things should be covered. If you need
362 # some extra libraries, please just add a libs = [ "foo.lib" ] to your 362 # some extra libraries, please just add a libs = [ "foo.lib" ] to your
363 # target that needs it. 363 # target that needs it.
364 ] 364 ]
365 } else if (is_android) { 365 } else if (is_android) {
366 # Android uses -nostdlib so we need to add even libc here.
367 libs = [ 366 libs = [
368 # TODO(brettw) write a version of this, hopefully we can express this
369 # without forking out to GCC just to get the library name. The android
370 # toolchain directory should probably be extracted into a .gni file that
371 # this file and the android toolchain .gn file can share.
372 # # Manually link the libgcc.a that the cross compiler uses.
373 # '<!(<(android_toolchain)/*-gcc -print-libgcc-file-name)',
374 "c",
375 "dl", 367 "dl",
376 "m", 368 "m",
377 ] 369 ]
378 } else if (is_mac) { 370 } else if (is_mac) {
379 libs = [ 371 libs = [
380 "AppKit.framework", 372 "AppKit.framework",
381 "ApplicationServices.framework", 373 "ApplicationServices.framework",
382 "Carbon.framework", 374 "Carbon.framework",
383 "CoreFoundation.framework", 375 "CoreFoundation.framework",
384 "Foundation.framework", 376 "Foundation.framework",
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 # This error doesn't happen every time. In VS2013, it seems if the .pch 469 # This error doesn't happen every time. In VS2013, it seems if the .pch
478 # file doesn't exist, no error will be generated (probably MS tested this 470 # file doesn't exist, no error will be generated (probably MS tested this
479 # case but forgot the other one?). To reproduce this error, do a build, 471 # case but forgot the other one?). To reproduce this error, do a build,
480 # then delete the precompile.c.obj file, then build again. 472 # then delete the precompile.c.obj file, then build again.
481 cflags_c = [ "/wd4206" ] 473 cflags_c = [ "/wd4206" ]
482 } else if (is_mac && !is_official_build && !use_goma) { 474 } else if (is_mac && !is_official_build && !use_goma) {
483 precompiled_header = "build/precompile.h" 475 precompiled_header = "build/precompile.h"
484 precompiled_source = "//build/precompile.h" 476 precompiled_source = "//build/precompile.h"
485 } 477 }
486 } 478 }
OLDNEW
« no previous file with comments | « no previous file | build/config/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698