GN(android): Default libs logic from runtime_library -> default_libs

GN(android): Simplify android default libs logic

* Always use full path to libgcc.a
* Specify libs c, dl, m only once in either default_libs or runtime_library

Should be a no-op.

BUG=570406
Committed: https://crrev.com/8d8895cc227d9247c1172f235603c23d0be15ab4
Cr-Commit-Position: refs/heads/master@{#367877}

[agrieve, 2015-12-21 15:49:12]

Description was changed from

==========
GN(android): Default libs logic from runtime_library -> default_libs

Should be a no-op.

BUG=
==========

to

==========
GN(android): Default libs logic from runtime_library -> default_libs

Should be a no-op.

BUG=
==========

[agrieve, 2015-12-21 15:49:12]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2015-12-21 15:50:00]

On 2015/12/21 15:49:12, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:brettw@chromium.org

Noticed some libs were in both spots. Please advise if some settings should be
in runtime_library rather than default_libs.

[brettw, 2016-01-05 18:36:44]

https://codereview.chromium.org/1539353002/diff/1/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1539353002/diff/1/build/config/BUILD.gn#newco...
build/config/BUILD.gn:377: libs = [ "c++_shared" ]
On Linux the difference between SDK and runtime library is a bit less clear than
on Windows. But this stuff all seems more like a runtime library than an SDK
(thinking of standard library language features vs platform features as the
distinction). I also think it's nicer to have more stuff in the android-specific
file so there's less clutter in this shared file.

"dl" should probably stay here since it's an OS feature (and the Linux one is
here below). I don't actually know what's in libatomic.

[agrieve, 2016-01-06 02:09:35]

Description was changed from

==========
GN(android): Default libs logic from runtime_library -> default_libs

Should be a no-op.

BUG=
==========

to

==========
GN(android): Simplify android default libs logic

* Always use full path to libgcc.a
* Specify libs c, dl, m only once in either default_libs or runtime_library

Should be a no-op.

BUG=570406
==========

[agrieve, 2016-01-06 02:09:54]

https://codereview.chromium.org/1539353002/diff/1/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1539353002/diff/1/build/config/BUILD.gn#newco...
build/config/BUILD.gn:377: libs = [ "c++_shared" ]
On 2016/01/05 18:36:44, brettw wrote:
> On Linux the difference between SDK and runtime library is a bit less clear
than
> on Windows. But this stuff all seems more like a runtime library than an SDK
> (thinking of standard library language features vs platform features as the
> distinction). I also think it's nicer to have more stuff in the
android-specific
> file so there's less clutter in this shared file.
> 
> "dl" should probably stay here since it's an OS feature (and the Linux one is
> here below). I don't actually know what's in libatomic.

Looks like libatomic is along the same lines as libgcc:
https://gcc.gnu.org/wiki/Atomic/GCCMM

Moved things around based on your comments.

[agrieve, 2016-01-06 15:19:09]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-06 15:19:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539353002/20001

[commit-bot: I haz the power, 2016-01-06 16:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-06 16:03:09]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[brettw, 2016-01-06 18:11:24]

lgtm

[agrieve, 2016-01-06 18:21:11]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-01-06 18:21:11]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1539353002/#ps40001
(title: "fix try job failure due to lib order")

[commit-bot: I haz the power, 2016-01-06 18:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1539353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1539353002/40001

[commit-bot: I haz the power, 2016-01-06 19:28:12]

Description was changed from

==========
GN(android): Simplify android default libs logic

* Always use full path to libgcc.a
* Specify libs c, dl, m only once in either default_libs or runtime_library

Should be a no-op.

BUG=570406
==========

to

==========
GN(android): Simplify android default libs logic

* Always use full path to libgcc.a
* Specify libs c, dl, m only once in either default_libs or runtime_library

Should be a no-op.

BUG=570406
==========

[commit-bot: I haz the power, 2016-01-06 19:28:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-06 19:29:10]

Description was changed from

==========
GN(android): Simplify android default libs logic

* Always use full path to libgcc.a
* Specify libs c, dl, m only once in either default_libs or runtime_library

Should be a no-op.

BUG=570406
==========

to

==========
GN(android): Simplify android default libs logic

* Always use full path to libgcc.a
* Specify libs c, dl, m only once in either default_libs or runtime_library

Should be a no-op.

BUG=570406

Committed: https://crrev.com/8d8895cc227d9247c1172f235603c23d0be15ab4
Cr-Commit-Position: refs/heads/master@{#367877}
==========

[commit-bot: I haz the power, 2016-01-06 19:29:11]

Patchset 3 (id:??) landed as
https://crrev.com/8d8895cc227d9247c1172f235603c23d0be15ab4
Cr-Commit-Position: refs/heads/master@{#367877}