Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2865)

Unified Diff: chrome/test/chromedriver/session_commands.h

Issue 15393005: [chromedriver] Remove unnecessary round trips to Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/command_executor_impl.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/session_commands.h
diff --git a/chrome/test/chromedriver/session_commands.h b/chrome/test/chromedriver/session_commands.h
index 7557c81c00341b5759a87f4ad403c5f3df6ea0d5..5806e0a0274b525a3ee23c94c295dcc4b0b62ce8 100644
--- a/chrome/test/chromedriver/session_commands.h
+++ b/chrome/test/chromedriver/session_commands.h
@@ -18,7 +18,6 @@ class Value;
struct Session;
class Status;
-class WebView;
typedef base::Callback<Status(
Session* session,
@@ -95,43 +94,6 @@ Status ExecuteImplicitlyWait(
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value);
-// Executes an alert command.
-Status ExecuteAlertCommand(
- const SessionCommand& alert_command,
- Session* session,
- const base::DictionaryValue& params,
- scoped_ptr<base::Value>* value);
-
-// Returns whether an alert is open.
-Status ExecuteGetAlert(
- Session* session,
- const base::DictionaryValue& params,
- scoped_ptr<base::Value>* value);
-
-// Returns the text of the open alert.
-Status ExecuteGetAlertText(
- Session* session,
- const base::DictionaryValue& params,
- scoped_ptr<base::Value>* value);
-
-// Sets the value of the alert prompt.
-Status ExecuteSetAlertValue(
- Session* session,
- const base::DictionaryValue& params,
- scoped_ptr<base::Value>* value);
-
-// Accepts the open alert.
-Status ExecuteAcceptAlert(
- Session* session,
- const base::DictionaryValue& params,
- scoped_ptr<base::Value>* value);
-
-// Dismisses the open alert.
-Status ExecuteDismissAlert(
- Session* session,
- const base::DictionaryValue& params,
- scoped_ptr<base::Value>* value);
-
Status ExecuteIsLoading(
Session* session,
const base::DictionaryValue& params,
« no previous file with comments | « chrome/test/chromedriver/command_executor_impl.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698