third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp - Issue 1539133002: Oilpan: avoid heap allocation in MajorGCWrapperVisitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 1539133002: Oilpan: avoid heap allocation in MajorGCWrapperVisitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: still support traverse-only DOMWrapperTracer invocations Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

index 801aa58343f679f17581680a5161ca964526af4b..945d62b8e4f6b31cb824c75c297de4d6c3c2747e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

@@ -234,7 +234,7 @@ private:

}

v8::Isolate* m_isolate;

- WillBePersistentHeapVector<RawPtrWillBeMember<Node>> m_groupsWhichNeedRetainerInfo;

+ Vector<RawPtrWillBeUntracedMember<Node>> m_groupsWhichNeedRetainerInfo;

haraken 2015/12/30 16:00:14 Maybe worth adding a comment to explain why we nee

sof 2015/12/30 16:08:01 added explanatory comment.

int m_domObjectsWithPendingActivity;

bool m_liveRootGroupIdSet;

bool m_constructRetainedObjectInfos;

« no previous file with comments | « no previous file | no next file » | no next file with comments »