Make some field trials unforceable via command-line in the official build.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 465 matching lines @@
           chrome::HOST_DESKTOP_TYPE_NATIVE,
           "127.0.0.1",
           port,
           frontend_str);
     } else {
       DLOG(WARNING) << "Invalid http debugger port number " << port;
     }
   }
 }
 
+// Returns true if the field trial described by |name| is allowed to be forced
+// via --force-fieldtrials.
+bool IsForceableFieldTrial(const std::string& name) {
+#if defined(OFFICIAL_BUILD)
+  // A list of field trials which cannot be forced to a different value in the
+  // official build.
+  static const char* const kUnforceableFieldTrials[] = {
+    "SettingsEnforcement",
+  };
+  for (size_t i = 0; i < ARRAYSIZE_UNSAFE(KUnforceableFieldTrials); ++i) {
+    if (name == KUnforceableFieldTrials[i])

[Alexei Svitkine (slow), 2014/02/12 14:26:47]

KUnforceableFieldTrials -> kUnforceableFieldTrials.

Please make sure this compiles in official builds when landing code with that
ifdef.

[gab, 2014/02/12 15:59:19]

Right, I've already confirmed that it compiles/works locally when removing the
ifdef (see TEST section of this CL's description).

+      return false;
+  }
+#endif  // defined(OFFICIAL_BUILD)
+
+  return true;
+}
+
 // Heap allocated class that listens for first page load, kicks off stat
 // recording and then deletes itself.
 class LoadCompleteListener : public content::NotificationObserver {
  public:
   LoadCompleteListener() {
     registrar_.Add(this,
                    content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
                    content::NotificationService::AllSources());
   }
   virtual ~LoadCompleteListener() {}
@@ skipping 15 matching lines @@
 void InitializeAllPrefHashStores() {
   ProfileInfoCache& profile_info_cache =
       g_browser_process->profile_manager()->GetProfileInfoCache();
   size_t n_profiles = profile_info_cache.GetNumberOfProfiles();
   for (size_t i = 0; i < n_profiles; ++i) {
     base::FilePath profile_path =
         profile_info_cache.GetPathOfProfileAtIndex(i);
     chrome_prefs::InitializePrefHashStoreIfRequired(profile_path);
   }
 }
+
 }  // namespace
 
 namespace chrome_browser {
 
 // This error message is not localized because we failed to load the
 // localization data files.
 #if defined(OS_WIN)
 const char kMissingLocaleDataTitle[] = "Missing File Error";
 #endif
 
@@ skipping 68 matching lines @@
   if (command_line->HasSwitch(switches::kEnableBenchmarking))
     base::FieldTrial::EnableBenchmarking();
 
   // Ensure any field trials specified on the command line are initialized.
   // Also stop the metrics service so that we don't pollute UMA.
   if (command_line->HasSwitch(switches::kForceFieldTrials)) {
     // Create field trials without activating them, so that this behaves in a
     // consistent manner with field trials created from the server.
     bool result = base::FieldTrialList::CreateTrialsFromString(
         command_line->GetSwitchValueASCII(switches::kForceFieldTrials),
-        base::FieldTrialList::DONT_ACTIVATE_TRIALS);
+        base::FieldTrialList::DONT_ACTIVATE_TRIALS,
+        base::Bind(&IsForceableFieldTrial));
     CHECK(result) << "Invalid --" << switches::kForceFieldTrials
                   << " list specified.";
   }
   if (command_line->HasSwitch(switches::kForceVariationIds)) {
     // Create default variation ids which will always be included in the
     // X-Client-Data request header.
     chrome_variations::VariationsHttpHeaderProvider* provider =
         chrome_variations::VariationsHttpHeaderProvider::GetInstance();
     bool result = provider->SetDefaultVariationIds(
         command_line->GetSwitchValueASCII(switches::kForceVariationIds));
@@ skipping 1077 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif
 #endif
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }