Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 153913005: CGI scripts currently specify a mix of 'perl -w' and 'perl -wT'; fix that. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
blink-reviews
Visibility:
Public.

Description

CGI scripts currently specify a mix of 'perl -w' and 'perl -wT'; fix that. In order to run the Win32 Apache and be able to reuse the existing CGI scripts in the tests, we have to jump through some hoops and those hoops do not support having mixed command lines in the shebang lines for a given executable. R=scottmg@chromium.org BUG=30536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -59 lines) Patch
M LayoutTests/http/tests/cache/resources/cache-simulator.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cache/resources/current-time.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cache/resources/echo-no-store.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cache/resources/random.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cache/resources/random-cached.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cache/resources/random-cached-iframe.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cache/resources/random-max-age.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/cache/resources/subresource-failover-to-network.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/incremental/chunked-xsl-transformed-xml.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/incremental/doc-write-before-end.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/incremental/resources/slow-utf8-css.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/incremental/slow-utf8-html.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/incremental/slow-utf8-text.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/incremental/split-hex-entities.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/loading/resources/404-with-empty-body.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/loading/resources/404-with-empty-body-no-content-type.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/local/slow-css-pass.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/video-throttled-load.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/image-slow.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/image-slow-out-of-viewport.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/intrinsic-ratio-slow.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/percent-sign-in-form-data-field-name.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/post-echo-and-notify-done.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/script-slow1.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/script-slow2.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/slow-async-script.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/slow-defer-script.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/slow-png-load.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/slow-stylesheet.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/resources/svg-slow.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/xmltokenizer-do-not-crash.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/resources/slow-resource.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/resources/slow-resource-1-sec.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/resources/submit-to-fragment.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/resources/dump-post.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/resources/slow-resource.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/resources/load-and-stall.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/resources/post-and-verify.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/resources/post-and-verify-hybrid.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/resources/slow-script.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/resources/escape-form-data-field-names.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/storage/resources/callbacks-are-called-in-correct-context.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/slow-ahem-loading.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/hello-world.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/interactive-state.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/methods.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/print-content-type.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/cross-site-progress-events.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/get-set-cookie.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/get-utf-8.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/get-windows-1251.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/invalid-utf8-json.pl View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/post-echo.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/post-echo-as-ascii.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/post-echo-as-utf-8.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/print-query.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/print-referer.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types.cgi View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/workers/resources/methods.cgi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
6 years, 10 months ago (2014-02-05 20:08:39 UTC) #1
scottmg
I have no idea what a taint check is, but I'll assume you know what ...
6 years, 10 months ago (2014-02-05 20:13:50 UTC) #2
Dirk Pranke
On 2014/02/05 20:13:50, scottmg wrote: > I have no idea what a taint check is, ...
6 years, 10 months ago (2014-02-05 21:33:06 UTC) #3
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-05 21:33:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/153913005/1
6 years, 10 months ago (2014-02-05 21:33:27 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 23:56:34 UTC) #6
Message was sent while issue was closed.
Change committed as 166557

Powered by Google App Engine
This is Rietveld 408576698