| Index: src/optimizing-compiler-thread.cc
|
| diff --git a/src/optimizing-compiler-thread.cc b/src/optimizing-compiler-thread.cc
|
| index a040453e4284be23c782b79444847dbc680f7506..029c115fcab978f1beef82e7fcfdeca2c83efde3 100644
|
| --- a/src/optimizing-compiler-thread.cc
|
| +++ b/src/optimizing-compiler-thread.cc
|
| @@ -74,7 +74,6 @@ void OptimizingCompilerThread::Run() {
|
| { AllowHandleDereference allow_handle_dereference;
|
| FlushInputQueue(true);
|
| }
|
| - Release_Store(&queue_length_, static_cast<AtomicWord>(0));
|
| Release_Store(&stop_thread_, static_cast<AtomicWord>(CONTINUE));
|
| stop_semaphore_.Signal();
|
| // Return to start of consumer loop.
|
| @@ -114,11 +113,9 @@ void OptimizingCompilerThread::CompileNext() {
|
| osr_candidates_.RemoveElement(optimizing_compiler);
|
| ready_for_osr_.Add(optimizing_compiler);
|
| } else {
|
| - LockGuard<Mutex> mark_and_queue(&install_mutex_);
|
| - Heap::RelocationLock relocation_lock(isolate_->heap());
|
| - AllowHandleDereference ahd;
|
| - optimizing_compiler->info()->closure()->MarkForInstallingRecompiledCode();
|
| + LockGuard<Mutex> access_queue(&queue_mutex_);
|
| output_queue_.Enqueue(optimizing_compiler);
|
| + isolate_->stack_guard()->RequestInstallCode();
|
| }
|
| }
|
|
|
| @@ -137,13 +134,20 @@ void OptimizingCompilerThread::FlushInputQueue(bool restore_function_code) {
|
| }
|
| delete info;
|
| }
|
| + Release_Store(&queue_length_, static_cast<AtomicWord>(0));
|
| +
|
| + LockGuard<Mutex> access_osr_lists(&osr_list_mutex_);
|
| + osr_candidates_.Clear();
|
| }
|
|
|
|
|
| void OptimizingCompilerThread::FlushOutputQueue(bool restore_function_code) {
|
| OptimizingCompiler* optimizing_compiler;
|
| // The optimizing compiler is allocated in the CompilationInfo's zone.
|
| - while (output_queue_.Dequeue(&optimizing_compiler)) {
|
| + while (true) {
|
| + { LockGuard<Mutex> access_queue(&queue_mutex_);
|
| + if (!output_queue_.Dequeue(&optimizing_compiler)) break;
|
| + }
|
| CompilationInfo* info = optimizing_compiler->info();
|
| if (restore_function_code) {
|
| Handle<JSFunction> function = info->closure();
|
| @@ -152,7 +156,6 @@ void OptimizingCompilerThread::FlushOutputQueue(bool restore_function_code) {
|
| delete info;
|
| }
|
|
|
| - osr_candidates_.Clear();
|
| RemoveStaleOSRCandidates(0);
|
| }
|
|
|
| @@ -199,11 +202,11 @@ void OptimizingCompilerThread::Stop() {
|
| void OptimizingCompilerThread::InstallOptimizedFunctions() {
|
| ASSERT(!IsOptimizerThread());
|
| HandleScope handle_scope(isolate_);
|
| +
|
| OptimizingCompiler* compiler;
|
| while (true) {
|
| - { // Memory barrier to ensure marked functions are queued.
|
| - LockGuard<Mutex> marked_and_queued(&install_mutex_);
|
| - if (!output_queue_.Dequeue(&compiler)) return;
|
| + { LockGuard<Mutex> access_queue(&queue_mutex_);
|
| + if (!output_queue_.Dequeue(&compiler)) break;
|
| }
|
| Compiler::InstallOptimizedCode(compiler);
|
| }
|
|
|