Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1539113002: Cleanup CJS_PublicMethods (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup CJS_PublicMethods: - Use FXSYS_iswdigit() instead of CJS_PublicMethods::IsDigit(). - Ditto for FXSYS_iswalpha() and FXSYS_iswalnum(). - Change CJS_PublicMethods::ParseNormalDate() and CJS_PublicMethods::MakeRegularDate() to take an out parameter by ptr. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f84fd2b1dac1fcca41db84d162995c38af650614

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -88 lines) Patch
M fpdfsdk/src/javascript/PublicMethods.h View 4 chunks +4 lines, -8 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 24 chunks +51 lines, -67 lines 0 comments Download
M fpdfsdk/src/javascript/public_methods_embeddertest.cpp View 6 chunks +13 lines, -10 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Lei Zhang
5 years ago (2015-12-21 18:51:15 UTC) #3
Oliver Chang
lgtm
5 years ago (2015-12-21 18:59:41 UTC) #4
Lei Zhang
5 years ago (2015-12-21 19:08:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
f84fd2b1dac1fcca41db84d162995c38af650614 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698