Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1539103002: Change SdkBundle to better fit its usage by SummaryResynthesizer. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change SdkBundle to better fit its usage by SummaryResynthesizer. This is probably a better format for using with FlatBuffers - we don't need to read every library to find an unlinked unit. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/69723d3388994e9390edfc04dfa93738e6ee6dad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -79 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 4 chunks +30 lines, -55 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summary.dart View 2 chunks +14 lines, -9 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +7 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-20 06:25:12 UTC) #1
Paul Berry
lgtm
5 years ago (2015-12-20 15:32:44 UTC) #2
scheglov
5 years ago (2015-12-20 18:27:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
69723d3388994e9390edfc04dfa93738e6ee6dad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698