Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1539073002: Revert of [arm64] Improve some new builtins. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [arm64] Improve some new builtins. (patchset #1 id:1 of https://codereview.chromium.org/1537903004/ ) Reason for revert: [Sheriff] Breaks arm64 nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/753 Original issue's description: > [arm64] Improve some new builtins. > > - Simplify the variable-length pop sequence on entry. (It now uses > smaller code with no branches.) > - Use conditional compare to merge branches where appropriate. > - Make use of Ldrsw + UntagSmiFieldMemOperand to load smis more > efficiently. > - Only load 'undefined' and 'null' once per builtin. > - A few other small improvements. > > BUG= > > Committed: https://crrev.com/efc641a7be54978cd85a4dcdf1950cd97725917d > Cr-Commit-Position: refs/heads/master@{#32975} TBR=bmeurer@chromium.org,yangguo@chromium.org,jacob.bramley@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/826afb309a2daf1372f264f31cd8d14eae3ecd25 Cr-Commit-Position: refs/heads/master@{#32978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -228 lines) Patch
M src/arm64/builtins-arm64.cc View 7 chunks +165 lines, -228 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [arm64] Improve some new builtins.
5 years ago (2015-12-19 07:54:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539073002/1
5 years ago (2015-12-19 07:54:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-19 07:55:10 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-19 07:55:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/826afb309a2daf1372f264f31cd8d14eae3ecd25
Cr-Commit-Position: refs/heads/master@{#32978}

Powered by Google App Engine
This is Rietveld 408576698