Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1539033002: js_runtime tweaks for better code (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

js_runtime tweaks for better code 1. Help type inference infer constant maps have a .length that is a non-null subtype of int. On some programs this means dynamic.length can be inferred as non-null int. 2. Make arity dispatch interceptor free by comparing constants-first (via a switch statement). R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d2c403704c5cd13779a00eee22894158a50fdc59

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/constant_map.dart View 4 chunks +10 lines, -6 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 2 chunks +24 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sra1
5 years ago (2015-12-19 02:29:47 UTC) #3
sra1
Shaves about 1k off swarm unminified.
5 years ago (2015-12-19 02:30:42 UTC) #4
Siggi Cherem (dart-lang)
lgtm
5 years ago (2015-12-21 18:30:39 UTC) #6
sra1
5 years ago (2015-12-21 21:30:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
d2c403704c5cd13779a00eee22894158a50fdc59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698