Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1539018: Mac: Make image dragging 162.4% more awesome. (Closed)

Created:
10 years, 8 months ago by Nico
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Mac: Make image dragging 162.4% more awesome. Also needs a webkit patch to do anything ( https://bugs.webkit.org/show_bug.cgi?id=37069 ), but can be landed independently. BUG=11457, 18992 TEST=(all require the webkit patch, so this won't work yet) http://html5demos.com/drag and http://ljouanneau.com/lab/html5/demodragdrop.html Dragging should show image http://www.google.com/ Dragging google image should show image http://www.travelvivi.com/wp-content/uploads/2009/09/Eiffel_Tower.jpg Dragging image should work, drag image should be smaller than image itself Random website Mark some text, drag it. Should show drag cursor and no image Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43631

Patch Set 1 #

Patch Set 2 : correct offset #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M chrome/browser/cocoa/web_drag_source.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/web_drag_source.mm View 1 2 5 chunks +17 lines, -11 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 4 chunks +13 lines, -4 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
The skbitmap->cgimage conversion isn't as bad as it looks, because the renderer side scales the ...
10 years, 8 months ago (2010-04-04 04:03:55 UTC) #1
pink (ping after 24hrs)
10 years, 8 months ago (2010-04-05 17:03:48 UTC) #2
L 162.4% GTM

Powered by Google App Engine
This is Rietveld 408576698