Change String::WriteUtf8() to return characters written.

Change String::WriteUtf8() to return characters written.

Explanation:
http://groups.google.com/group/v8-users/browse_thread/thread/6a7d6bb735196336

[ry, 2010-04-01 20:14:29]

Return number of characters written in String::WriteUtf8(). Explanation here
http://groups.google.com/group/v8-users/browse_thread/thread/6a7d6bb735196336

[antonm, 2010-04-02 11:27:38]

Christian is less involved with v8 these days.

It's mostly lgtm (modulo minor stylistic nits).  I hope it won't affect
performance (it shouldn't)---writing strings out is on some hot paths---but we
need to land this patch to check it.

http://codereview.chromium.org/1539013/diff/1/3
File src/api.cc (right):

http://codereview.chromium.org/1539013/diff/1/3#newcode2642
src/api.cc:2642: int String::WriteUtf8(char* buffer, int capacity, int
*ncharsRef) const {
nit: v8 style is to use nchars_ref and * immediately after the type.

http://codereview.chromium.org/1539013/diff/1/3#newcode2682
src/api.cc:2682: if (ncharsRef) *ncharsRef = nchars;
nit: v8 style is explicit check against NULL (not 0):


if (nchars_ref != NULL) *nchars_ref = nchars;

http://codereview.chromium.org/1539013/diff/1/4
File test/cctest/test-strings.cc (right):

http://codereview.chromium.org/1539013/diff/1/4#newcode326
test/cctest/test-strings.cc:326: const int charLengths[12] = {0, 0, 1, 2, 2, 2,
3, 4, 4, 4, 5, 5};
ditto for charLengths (char_lengths) and charsWritten (chars_written)

[ry, 2010-04-02 18:56:28]

I fixed the style issues.

[antonm, 2010-04-06 10:45:56]

I am going to land it with one minor alternation: I'd rather use nchars_ref in
inlcude/v8.h to match src/api.cc, is it fine with you?

And just to double check---you have your committer agreement signed, correct?

[ry, 2010-04-06 17:01:45]

On 2010/04/06 10:45:56, antonm wrote:
> I am going to land it with one minor alternation: I'd rather use nchars_ref in
> inlcude/v8.h to match src/api.cc, is it fine with you?

Okay.

> And just to double check---you have your committer agreement signed, correct?

Yes.