Chromium Code Reviews
Help | Chromium Project | Sign in
(401)

Issue 1539013: Change String::WriteUtf8() to return characters written. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by ry
Modified:
2 years, 11 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Change String::WriteUtf8() to return characters written.

Explanation:
http://groups.google.com/group/v8-users/browse_thread/thread/6a7d6bb735196336

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix style issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Lint Patch
M include/v8.h View 1 chunk +5 lines, -2 lines 0 comments 1 errors Download
M src/api.cc View 1 3 chunks +5 lines, -1 line 0 comments 0 errors Download
M test/cctest/test-strings.cc View 1 2 chunks +4 lines, -1 line 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 5
ry
Return number of characters written in String::WriteUtf8(). Explanation here http://groups.google.com/group/v8-users/browse_thread/thread/6a7d6bb735196336
4 years ago #1
antonm
Christian is less involved with v8 these days. It's mostly lgtm (modulo minor stylistic nits). ...
4 years ago #2
ry
I fixed the style issues.
4 years ago #3
antonm
I am going to land it with one minor alternation: I'd rather use nchars_ref in ...
4 years ago #4
ry
4 years ago #5
On 2010/04/06 10:45:56, antonm wrote:
> I am going to land it with one minor alternation: I'd rather use nchars_ref in
> inlcude/v8.h to match src/api.cc, is it fine with you?

Okay.

> And just to double check---you have your committer agreement signed, correct?

Yes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6