Enable download resumption by default.

Enable download resumption by default.

BUG=7648
Committed: https://crrev.com/dc5a2994948c060ab7c3a584107fa7ba21ee1486
Cr-Commit-Position: refs/heads/master@{#366264}

[asanka, 2015-12-18 19:21:56]

Description was changed from

==========
Enable download resumption by default.

BUG=7648
==========

to

==========
Enable download resumption by default.

BUG=7648
==========

[asanka, 2015-12-18 19:21:56]

asanka@chromium.org changed reviewers:
+ asvitkine@chromium.org, benjhayden@chromium.org, davidben@chromium.org

[asanka, 2015-12-18 19:25:36]

benjhayden:
  chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc

davidben:
  content/public/common/content_features.cc
  content/public/common/content_features.h
  content/public/common/content_switches.cc
  content/public/common/content_switches.h

asvitkine:
  Chunks to review are called out in comments as "+asvitkine: ^^^". I'd be happy
to add a suitable method to FeatureList so that we don't have to replace the
FeatureList singleton for testing.

https://codereview.chromium.org/1538933002/diff/20001/chrome/browser/download...
File chrome/browser/download/download_browsertest.cc (right):

https://codereview.chromium.org/1538933002/diff/20001/chrome/browser/download...
chrome/browser/download/download_browsertest.cc:459:
base::FeatureList::SetInstance(std::move(feature_list));
+asvitkine: ^^^

https://codereview.chromium.org/1538933002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
(right):

https://codereview.chromium.org/1538933002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc:316:
base::FeatureList::SetInstance(std::move(feature_list));
+asvitkine: ^^^

https://codereview.chromium.org/1538933002/diff/20001/content/browser/downloa...
File content/browser/download/download_browsertest.cc (right):

https://codereview.chromium.org/1538933002/diff/20001/content/browser/downloa...
content/browser/download/download_browsertest.cc:717: 
+asvitkine: ^^^

https://codereview.chromium.org/1538933002/diff/20001/content/browser/downloa...
File content/browser/download/download_item_impl_unittest.cc (right):

https://codereview.chromium.org/1538933002/diff/20001/content/browser/downloa...
content/browser/download/download_item_impl_unittest.cc:199:
base::FeatureList::SetInstance(std::move(feature_list));
+asvitkine: ^^^

[Alexei Svitkine (slow), 2015-12-18 20:46:10]

lgtm, exciting to see this go in!

(We're finally caught to feature parity with Mac IE 5 from 2000! :P)

https://codereview.chromium.org/1538933002/diff/40001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/1538933002/diff/40001/content/public/common/c...
content/public/common/content_features.cc:13: const base::Feature
kDownloadResumption = {
Nit: Use same syntax as the ones below (no =).

[asanka, 2015-12-18 22:07:52]

Thanks!

https://codereview.chromium.org/1538933002/diff/40001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/1538933002/diff/40001/content/public/common/c...
content/public/common/content_features.cc:13: const base::Feature
kDownloadResumption = {
On 2015/12/18 20:46:10, Alexei Svitkine (slow) wrote:
> Nit: Use same syntax as the ones below (no =).

Done.

[benjhayden, 2015-12-18 23:00:40]

lgtm

[davidben, 2015-12-18 23:26:59]

content/public/common lgtm. Didn't look at the rest.

[asanka, 2015-12-19 01:53:27]

The CQ bit was checked by asanka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-19 01:53:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538933002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538933002/60001

[commit-bot: I haz the power, 2015-12-19 03:02:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-19 03:02:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[asanka, 2015-12-19 04:12:30]

The CQ bit was checked by asanka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-19 04:12:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538933002/80001

[asanka, 2015-12-19 04:18:45]

The CQ bit was checked by asanka@chromium.org

[asanka, 2015-12-19 04:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, benjhayden@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1538933002/#ps80001
(title: "Forgot ChromeOS")

[commit-bot: I haz the power, 2015-12-19 04:18:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1538933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1538933002/80001

[commit-bot: I haz the power, 2015-12-19 04:45:50]

Description was changed from

==========
Enable download resumption by default.

BUG=7648
==========

to

==========
Enable download resumption by default.

BUG=7648
==========

[commit-bot: I haz the power, 2015-12-19 04:45:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-19 04:46:50]

Description was changed from

==========
Enable download resumption by default.

BUG=7648
==========

to

==========
Enable download resumption by default.

BUG=7648

Committed: https://crrev.com/dc5a2994948c060ab7c3a584107fa7ba21ee1486
Cr-Commit-Position: refs/heads/master@{#366264}
==========

[commit-bot: I haz the power, 2015-12-19 04:46:51]

Patchset 5 (id:??) landed as
https://crrev.com/dc5a2994948c060ab7c3a584107fa7ba21ee1486
Cr-Commit-Position: refs/heads/master@{#366264}