Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 153893011: Fix interactive_ui_tests dependency on xtst (Closed)

Created:
6 years, 10 months ago by jamesr
Modified:
6 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Fix interactive_ui_tests dependency on xtst chrome/browser/extensions/extension_commands_global_registry_apitest.cc, which is linked into interactive_ui_tests, uses some functions from libXtst and thus should declare a dependency on xtst. The only other file that uses the XTest.h header is in remoting, which declares an xtst dependency already. This lets us drop the dependency from glib on xtst since most targets don't need it. R=phajdan.jr BUG=339518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250585

Patch Set 1 #

Total comments: 1

Patch Set 2 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/linux/system.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
Depends on https://codereview.chromium.org/151713003/. Landing separately in case it breaks some obscure build config.
6 years, 10 months ago (2014-02-10 23:08:02 UTC) #1
Paweł Hajdan Jr.
LGTM with a comment, nice cleanup. :) https://codereview.chromium.org/153893011/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/153893011/diff/1/chrome/chrome_tests.gypi#newcode266 chrome/chrome_tests.gypi:266: '../build/linux/system.gyp:xtst', nit: ...
6 years, 10 months ago (2014-02-11 00:16:12 UTC) #2
jamesr
Oops, thanks. chrome/*gypi* is technically OWNERS=*, although the comments say just for file renames. Since ...
6 years, 10 months ago (2014-02-11 00:21:58 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-11 21:25:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/153893011/70001
6 years, 10 months ago (2014-02-11 21:38:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/153893011/70001
6 years, 10 months ago (2014-02-11 22:13:29 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 01:00:43 UTC) #7
Message was sent while issue was closed.
Change committed as 250585

Powered by Google App Engine
This is Rietveld 408576698