Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 153893005: Makes it easier to snap or dock windows near the edges when using touch (Closed)

Created:
6 years, 10 months ago by varkha
Modified:
6 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Makes it easier to snap or dock windows near the edges when using touch. This is a followup on https://codereview.chromium.org/58973004/ to make the subsequent drags in the snapping sequence use the same touch fuzzing as the initial drag. BUG=316645 TEST=ash_unittests --gtest_filter=*SystemGestureEventFilterTest.Drag*NearEdgeSnaps* TEST=Manual: 1. Snap a 500px wide browser window using touch screen. 2. Continue drag to dock a window. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M ash/wm/workspace/snap_sizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/workspace/snap_sizer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 4 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
varkha
jamescook@, Could you please take a look? I have noticed that despite https://codereview.chromium.org/58973004/ touch docking ...
6 years, 10 months ago (2014-02-04 16:09:37 UTC) #1
varkha
jamescook@, Could you please take a look? I have noticed that despite https://codereview.chromium.org/58973004/ touch docking ...
6 years, 10 months ago (2014-02-04 16:11:04 UTC) #2
James Cook
lgtm
6 years, 10 months ago (2014-02-04 18:18:54 UTC) #3
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 10 months ago (2014-02-04 18:29:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/153893005/1
6 years, 10 months ago (2014-02-04 18:37:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests ...
6 years, 10 months ago (2014-02-04 20:36:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/153893005/1
6 years, 10 months ago (2014-02-04 20:40:45 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 23:11:47 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests ...
6 years, 10 months ago (2014-02-04 23:11:47 UTC) #9
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 10 months ago (2014-02-05 00:37:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/153893005/1
6 years, 10 months ago (2014-02-05 03:47:20 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 05:19:46 UTC) #12
Message was sent while issue was closed.
Change committed as 248857

Powered by Google App Engine
This is Rietveld 408576698