Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 153893004: Added root deletion code to fix valgrind error (Closed)

Created:
6 years, 10 months ago by sugoi1
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Added root deletion code to fix valgrind error BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13308

Patch Set 1 #

Patch Set 2 : Trying again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/core/SkQuadTree.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
sugoi1
6 years, 10 months ago (2014-02-04 15:39:51 UTC) #1
robertphillips
lgtm
6 years, 10 months ago (2014-02-04 15:40:20 UTC) #2
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 10 months ago (2014-02-04 15:44:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/153893004/1
6 years, 10 months ago (2014-02-04 15:44:35 UTC) #4
skia-commit-bot
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/153893004/1
6 years, 10 months ago (2014-02-04 15:44:36 UTC) #5
skia-commit-bot
The CQ bit was unchecked by skia-commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 15:44:37 UTC) #6
skia-commit-bot
Failed to apply patch for src/core/SkQuadTree.cpp: While running git apply --index -p1; Created missing directory ...
6 years, 10 months ago (2014-02-04 15:44:37 UTC) #7
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 10 months ago (2014-02-04 15:51:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/153893004/110001
6 years, 10 months ago (2014-02-04 15:51:34 UTC) #9
skia-commit-bot
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/153893004/110001
6 years, 10 months ago (2014-02-04 15:51:36 UTC) #10
skia-commit-bot
The CQ bit was unchecked by skia-commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 15:51:37 UTC) #11
skia-commit-bot
Failed to apply patch for src/core/SkQuadTree.cpp: While running git apply --index -p1; error: src/core/SkQuadTree.cpp: does ...
6 years, 10 months ago (2014-02-04 15:51:38 UTC) #12
sugoi1
The CQ bit was checked by sugoi@chromium.org
6 years, 10 months ago (2014-02-04 16:14:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/153893004/110001
6 years, 10 months ago (2014-02-04 16:14:55 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 17:49:59 UTC) #15
Message was sent while issue was closed.
Change committed as 13308

Powered by Google App Engine
This is Rietveld 408576698