Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: cc/playback/display_item_list_unittest.cc

Issue 1538913002: cc: Restore GPU suitability check in cached_picture case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add unit tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/display_item_list.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_item_list_unittest.cc
diff --git a/cc/playback/display_item_list_unittest.cc b/cc/playback/display_item_list_unittest.cc
index 9c65c7b1fb933da568e45e97d21e7a6f6188d928..65d12d69cccc7ed55107f07a30656cd0c4af059e 100644
--- a/cc/playback/display_item_list_unittest.cc
+++ b/cc/playback/display_item_list_unittest.cc
@@ -527,26 +527,43 @@ TEST(DisplayItemListTest, IsSuitableForGpuRasterizationWithCachedPicture) {
paint.setAntiAlias(true);
canvas->drawPath(path, paint);
- list->CreateAndAppendItem<DrawingDisplayItem>(
- kVisualRect, skia::AdoptRef(recorder.endRecordingAsPicture()));
+ skia::RefPtr<SkPicture> suitable_picture =
+ skia::AdoptRef(recorder.endRecordingAsPicture());
+ list->CreateAndAppendItem<DrawingDisplayItem>(kVisualRect, suitable_picture);
list->Finalize();
// A single DrawingDisplayItem with a large AA concave path shouldn't trigger
// a veto.
EXPECT_TRUE(list->IsSuitableForGpuRasterization());
+ // Now check the RasterIntoCanvas path.
+ list = DisplayItemList::Create(layer_rect, settings);
+ DrawingDisplayItem suitable_item(suitable_picture);
+ list->RasterIntoCanvas(suitable_item);
+ list->Finalize();
+ EXPECT_TRUE(list->IsSuitableForGpuRasterization());
+
list = DisplayItemList::Create(layer_rect, settings);
canvas =
skia::SharePtr(recorder.beginRecording(gfx::RectToSkRect(layer_rect)));
for (int i = 0; i < 10; ++i)
canvas->drawPath(path, paint);
- list->CreateAndAppendItem<DrawingDisplayItem>(
- kVisualRect, skia::AdoptRef(recorder.endRecordingAsPicture()));
+ skia::RefPtr<SkPicture> unsuitable_picture =
+ skia::AdoptRef(recorder.endRecordingAsPicture());
+ list->CreateAndAppendItem<DrawingDisplayItem>(kVisualRect,
+ unsuitable_picture);
list->Finalize();
// A single DrawingDisplayItem with several large AA concave paths should
// trigger a veto.
EXPECT_FALSE(list->IsSuitableForGpuRasterization());
+
+ // Now check the RasterIntoCanvas path.
+ list = DisplayItemList::Create(layer_rect, settings);
+ DrawingDisplayItem unsuitable_item(unsuitable_picture);
+ list->RasterIntoCanvas(unsuitable_item);
+ list->Finalize();
+ EXPECT_FALSE(list->IsSuitableForGpuRasterization());
}
TEST(DisplayItemListTest, IsSuitableForGpuRasterizationWithoutCachedPicture) {
« no previous file with comments | « cc/playback/display_item_list.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698