Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1538913002: cc: Restore GPU suitability check in cached_picture case. (Closed)

Created:
5 years ago by Stephen White
Modified:
5 years ago
Reviewers:
danakj, vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Restore GPU suitability check in cached_picture case. BUG=571033 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8d842943f35e5be9cb5607dc948aafd600f018cb Cr-Commit-Position: refs/heads/master@{#366226}

Patch Set 1 #

Patch Set 2 : add unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M cc/playback/display_item_list.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 1 1 chunk +21 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
Stephen White
enne@: PTAL. Thanks! (This should be covered by DisplayItemListTest, IsSuitableForGpuRasterizationWithCachedPicture, but it isn't failing in ...
5 years ago (2015-12-18 18:16:01 UTC) #4
danakj
On Fri, Dec 18, 2015 at 10:16 AM, <senorblanco@chromium.org> wrote: > Reviewers: enne > CL: ...
5 years ago (2015-12-18 18:41:31 UTC) #5
Stephen White
On 2015/12/18 18:41:31, danakj (behind on reviews) wrote: > On Fri, Dec 18, 2015 at ...
5 years ago (2015-12-18 19:21:02 UTC) #6
Stephen White
On 2015/12/18 19:21:02, Stephen White wrote: > On 2015/12/18 18:41:31, danakj (behind on reviews) wrote: ...
5 years ago (2015-12-18 20:08:37 UTC) #7
danakj
+vmpstr
5 years ago (2015-12-18 20:39:51 UTC) #9
Stephen White
I tried adding two more subtests which serialize & deserialize the DisplayItemList, but the second ...
5 years ago (2015-12-18 20:44:32 UTC) #10
vmpstr
Chrome wouldn't be calling proto related things, since that's exclusively Blimp (and it's not quite ...
5 years ago (2015-12-18 20:44:54 UTC) #11
Stephen White
On 2015/12/18 20:44:54, vmpstr wrote: > Chrome wouldn't be calling proto related things, since that's ...
5 years ago (2015-12-18 21:00:21 UTC) #12
Stephen White
On 2015/12/18 21:00:21, Stephen White wrote: > On 2015/12/18 20:44:54, vmpstr wrote: > > Chrome ...
5 years ago (2015-12-18 21:01:26 UTC) #13
nyquist
On 2015/12/18 20:44:54, vmpstr wrote: > Chrome wouldn't be calling proto related things, since that's ...
5 years ago (2015-12-18 21:10:33 UTC) #14
Stephen White
After chatting with Vlad, we're guessing it's calling the RasterIntoCanvas() fast path, and not the ...
5 years ago (2015-12-18 21:14:39 UTC) #15
Stephen White
Unit tests added. PTAL. (Note that I'm stack-allocating a DisplayItem. Hope that's ok.)
5 years ago (2015-12-18 22:13:22 UTC) #16
vmpstr
lgtm, thanks
5 years ago (2015-12-18 23:12:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538913002/20001
5 years ago (2015-12-18 23:15:37 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-19 00:18:16 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-19 00:19:23 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d842943f35e5be9cb5607dc948aafd600f018cb
Cr-Commit-Position: refs/heads/master@{#366226}

Powered by Google App Engine
This is Rietveld 408576698