Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1538863002: Enable NVPR with command buffer (Closed)

Created:
5 years ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable NVPR with command buffer Set Chromium command-line flag --enable-gl-path-rendering before creating command buffer context. This is needed for the command buffer to expose NVPR at the moment. BUG=skia:2992 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1538863002 Committed: https://skia.googlesource.com/skia/+/dd180e795fcdf0ff424e753c7a822fad1ca8a700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M gyp/ports.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/command_buffer/SkCommandBufferGLContext.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
A src/ports/SkOSEnvironment.h View 1 chunk +15 lines, -0 lines 0 comments Download
A src/ports/SkOSEnvironment.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M tests/RTConfRegistryTest.cpp View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Kimmo Kinnunen
5 years ago (2015-12-18 13:11:08 UTC) #3
bsalomon
lgtm
5 years ago (2015-12-18 14:23:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538863002/1
5 years ago (2015-12-21 11:15:50 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-21 11:30:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538863002/1
5 years ago (2015-12-21 12:04:54 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-21 12:05:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd180e795fcdf0ff424e753c7a822fad1ca8a700

Powered by Google App Engine
This is Rietveld 408576698