Chromium Code Reviews| Index: Source/core/svg/SVGAnimatedType.cpp |
| diff --git a/Source/core/svg/SVGAnimatedType.cpp b/Source/core/svg/SVGAnimatedType.cpp |
| index 6c93bab8eaa2e7d14f2340772252b04e0eb0f7d5..eca8dc41b435e6a5d0628cc9ae712747c6a55968 100644 |
| --- a/Source/core/svg/SVGAnimatedType.cpp |
| +++ b/Source/core/svg/SVGAnimatedType.cpp |
| @@ -49,9 +49,6 @@ SVGAnimatedType::~SVGAnimatedType() |
| case AnimatedPath: |
| delete m_data.path; |
| break; |
| - case AnimatedTransformList: |
| - delete m_data.transformList; |
| - break; |
| // Below properties are migrated to new property implementation. |
| case AnimatedBoolean: |
| case AnimatedColor: |
| @@ -65,11 +62,14 @@ SVGAnimatedType::~SVGAnimatedType() |
| case AnimatedRect: |
| case AnimatedString: |
| case AnimatedStringList: |
| + case AnimatedTransformList: |
| // handled by RefPtr |
| break; |
| - // There is no SVGAnimatedPoint |
| + // There is no SVGAnimated{Point,Matrix,Transform} |
| case AnimatedPoint: |
| + case AnimatedMatrix: |
|
haraken
2014/02/11 17:00:21
Alphabetical order please.
kouhei (in TOK)
2014/02/12 01:57:49
Removed matrix.
|
| + case AnimatedTransform: |
| ASSERT_NOT_REACHED(); |
| break; |
| @@ -119,14 +119,6 @@ PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createPath(PassOwnPtr<SVGPathByteSt |
| return animatedType.release(); |
| } |
| -PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createTransformList(SVGTransformList* transformList) |
| -{ |
| - ASSERT(transformList); |
| - OwnPtr<SVGAnimatedType> animatedType = adoptPtr(new SVGAnimatedType(AnimatedTransformList)); |
| - animatedType->m_data.transformList = transformList; |
| - return animatedType.release(); |
| -} |
| - |
| PassOwnPtr<SVGAnimatedType> SVGAnimatedType::createNewProperty(PassRefPtr<NewSVGPropertyBase> newProperty) |
| { |
| ASSERT(newProperty); |
| @@ -160,6 +152,8 @@ String SVGAnimatedType::valueAsString() |
| case AnimatedIntegerOptionalInteger: |
| case AnimatedPath: |
| case AnimatedPoint: |
| + case AnimatedMatrix: |
|
haraken
2014/02/11 17:00:21
Ditto.
|
| + case AnimatedTransform: |
| case AnimatedTransformList: |
| case AnimatedUnknown: |
| // Only SVG DOM animations use these property types - that means valueAsString() is never used for those. |
| @@ -196,6 +190,8 @@ bool SVGAnimatedType::setValueAsString(const QualifiedName& attrName, const Stri |
| case AnimatedIntegerOptionalInteger: |
| case AnimatedPath: |
| case AnimatedPoint: |
| + case AnimatedMatrix: |
|
haraken
2014/02/11 17:00:21
Ditto.
|
| + case AnimatedTransform: |
| case AnimatedTransformList: |
| case AnimatedUnknown: |
| // Only SVG DOM animations use these property types - that means setValueAsString() is never used for those. |