third_party/WebKit/PRESUBMIT.py - Issue 1538803002: Migrates battery_status from content/renderer/ to WebKit/platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/PRESUBMIT.py

Issue 1538803002: Migrates battery_status from content/renderer/ to WebKit/platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a TODO comment. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/blink/BUILD.gn ('k') | third_party/WebKit/Source/modules/battery/BatteryDispatcher.h » ('j') | third_party/WebKit/Source/modules/battery/BatteryDispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/PRESUBMIT.py

diff --git a/third_party/WebKit/PRESUBMIT.py b/third_party/WebKit/PRESUBMIT.py

index 8d073343a52f62e7880fe77effdc74e4692f894d..af04a8a807a51c194c517507eef6393ecdd54de7 100644

--- a/third_party/WebKit/PRESUBMIT.py

+++ b/third_party/WebKit/PRESUBMIT.py

@@ -8,6 +8,7 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

for more details about the presubmit API built into gcl.

"""

+import re

import sys

@@ -113,11 +114,15 @@ def _CheckTestExpectations(input_api, output_api):

def _CheckStyle(input_api, output_api):

+ # Files that follow Chromium's coding style do not include capital letters.

+ re_chromium_style_file = re.compile(r'\b[a-z_]+\.(cc|h)$')

style_checker_path = input_api.os_path.join(input_api.PresubmitLocalPath(),

'Tools', 'Scripts', 'check-webkit-style')

args = ([input_api.python_executable, style_checker_path, '--diff-files']

+ [input_api.os_path.join('..', '..', f.LocalPath())

- for f in input_api.AffectedFiles()])

+ for f in input_api.AffectedFiles()

+ # Filter out files that follow Chromium's coding style.

+ if not re_chromium_style_file.search(f.LocalPath())])

results = []

try: