third_party/WebKit/Source/platform/base/DEPS - Issue 1538803002: Migrates battery_status from content/renderer/ to WebKit/platform/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/base/DEPS

Issue 1538803002: Migrates battery_status from content/renderer/ to WebKit/platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: BatteryStatusDispatcher => BatteryDispatcherProxy Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/base/Bind.h ('K') | « third_party/WebKit/Source/platform/base/Bind.h ('k') | third_party/WebKit/Source/platform/battery/DEPS » ('j') | third_party/WebKit/Source/platform/battery/battery_dispatcher_proxy.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # To whitelist base/ stuff Blink is allowed to include, we list up all	2 # To whitelist base/ stuff Blink is allowed to include, we list up all

3 # directories and files instead of writing 'base/'.	3 # directories and files instead of writing 'base/'.

4 "+base/bind.h",	4 "+base/bind.h",

5 "+base/threading",	5 "+mojo/public/cpp/bindings/callback.h",
	kinuko 2016/02/16 10:09:18 nit: What other files are we going to put in this nit: What other files are we going to put in this new directory? 'base/' feels very generic to imagine what to expect, maybe 'mojo/' could work? Or could we have the new (and tentative) bind.h under platform/threading? Yuki 2016/02/16 13:21:59 I moved platform/base/Bind.h to platform/threading Show quoted text On 2016/02/16 10:09:18, kinuko wrote: > nit: What other files are we going to put in this new directory? 'base/' feels > very generic to imagine what to expect, maybe 'mojo/' could work? Or could we > have the new (and tentative) bind.h under platform/threading? I moved platform/base/Bind.h to platform/threading/BindForMojo.h . Does this look better?
6 ]	6 ]

OLD	NEW