third_party/WebKit/Source/platform/DEPS - Issue 1538803002: Migrates battery_status from content/renderer/ to WebKit/platform/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/DEPS

Issue 1538803002: Migrates battery_status from content/renderer/ to WebKit/platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: BatteryStatusDispatcher => BatteryDispatcherProxy Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/battery/BatteryDispatcher.h ('K') | « third_party/WebKit/Source/platform/BUILD.gn ('k') | third_party/WebKit/Source/platform/base/Bind.h » ('j') | third_party/WebKit/Source/platform/base/Bind.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # To whitelist base/ stuff Blink is allowed to include, we list up all	2 # To whitelist base/ stuff Blink is allowed to include, we list up all

3 # directories and files instead of writing 'base/'.	3 # directories and files instead of writing 'base/'.

4 "+base/json",	4 "+base/json",

5 "+base/location.h",	5 "+base/location.h",

6 "+base/metrics/histogram.h",	6 "+base/metrics/histogram.h",

7 "+base/metrics/sparse_histogram.h",	7 "+base/metrics/sparse_histogram.h",

8 "+base/synchronization/waitable_event.h",	8 "+base/synchronization/waitable_event.h",

9 "+base/memory",	9 "+base/memory",

10 "+base/sys_info.h",	10 "+base/sys_info.h",

11 "+base/time",	11 "+base/time",

12 "+base/trace_event",	12 "+base/trace_event",

13 "+base/values.h",	13 "+base/values.h",
	haraken 2016/02/15 13:18:39 I wonder why you don't need to add base/message_lo I wonder why you don't need to add base/message_loop.h here while you're including base/message_loop.h in battery_dispatcher_proxy_unittest.cc. If you don't hit a presubmit error, is it a bug of DEPS analysis? Yuki 2016/02/16 07:31:58 https://codereview.chromium.org/1538803002/diff/81 Show quoted text On 2016/02/15 13:18:39, haraken wrote: > > I wonder why you don't need to add base/message_loop.h here while you're > including base/message_loop.h in battery_dispatcher_proxy_unittest.cc. If you > don't hit a presubmit error, is it a bug of DEPS analysis? https://codereview.chromium.org/1538803002/diff/810001/third_party/WebKit/Sou... I put "+base/message_loop.h" here. (and removed it according to another review comment from you.)
	14 "+device",

14 "+mozilla",	15 "+mozilla",

15 "+platform",	16 "+platform",

16 "+public/platform",	17 "+public/platform",

17 "+skia/ext",	18 "+skia/ext",

18 "+third_party/khronos",	19 "+third_party/khronos",

19 "+third_party/skia",	20 "+third_party/skia",

20 "+ui/gfx",	21 "+ui/gfx",

21 "+url",	22 "+url",

22 "+webp",	23 "+webp",

23 "-bindings",	24 "-bindings",

24 "-core",	25 "-core",

25 "-modules",	26 "-modules",

26 ]	27 ]

OLD	NEW