Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7667)

Unified Diff: chrome/renderer/resources/extensions/searchbox_api.js

Issue 15388002: Supporting high dpi favicons in Instant Extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index 7d2daa5668768f6e4961d43f43dee3bd12b72720..73b510d6bfa834f21a5a9b8d6563138d5d53eea2 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -263,16 +263,24 @@ if (!chrome.embeddedSearch) {
function GetMostVisitedItemsWrapper() {
var mostVisitedItems = GetMostVisitedItems();
for (var i = 0, item; item = mostVisitedItems[i]; ++i) {
+ item.faviconUrl = GenerateThumbnailURL(item.renderViewId, item.rid);
// These properties are private data and should not be returned to
// the page. They are only accessible via getMostVisitedItemData().
item.url = null;
item.title = null;
item.domain = null;
item.direction = null;
+ item.renderViewId = null;
}
return mostVisitedItems;
}
+ function GenerateThumbnailURL(renderViewId, rid) {
+ return "chrome-search://favicon/size/16@" +
+ window.devicePixelRatio + "x/" +
+ renderViewId + "/" + rid;
+ }
+
// =======================================================================
// Exported functions
// =======================================================================

Powered by Google App Engine
This is Rietveld 408576698