Supporting high dpi favicons in Instant Extended.

chrome/renderer/resources/extensions/searchbox_api.js

Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index bfc8405393304826956f1723304e610372783775..5847358ef6ee128ac2cdea23ec634e99e3f1aa73 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -333,6 +333,7 @@ if (!chrome.embeddedSearch) {
           // Google-provided NTP no longer depends on them.
           item.titleElement = SafeWrapMostVisited(title, 140, item.direction);
           item.domainElement = SafeWrapMostVisited(domain, 123);
+          item.faviconUrl = GenerateFaviconUrl(item.rid);

[sreeram, 2013/06/04 22:01:56]

These Shadow DOM elements are going to be removed soon. Given that, I don't see
the point of adding this here. You might as well just add this to the
local_ntp.js or wherever you need to compute it (given that there's no secret
ingredient anyway).

[pedro (no code reviews), 2013/06/07 23:34:21]

The faviconUrl will be used as the background image of a normal div, not a
Shadow DOM one, so I think it makes sense putting this code in here. By doing so
we'll make both the live and local NTPs to support high dpi favicons.

           // These properties are private data and should not be returned to
           // the page. They are only accessible via getMostVisitedItemData().
           item.url = null;
@@ -343,6 +344,11 @@ if (!chrome.embeddedSearch) {
         return mostVisitedItems;
       }
 
+      function GenerateFaviconUrl(rid) {
+        return "chrome-search://favicon/size/16@" +
+            window.devicePixelRatio + "x/" + rid;
+      }
+
       // =======================================================================
       //                           Exported functions
       // =======================================================================