chrome/browser/ui/webui/favicon_source.h - Issue 15388002: Supporting high dpi favicons in Instant Extended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/favicon_source.h

Issue 15388002: Supporting high dpi favicons in Instant Extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moving reusable pieces to chrome/common Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/favicon_source.h

diff --git a/chrome/browser/ui/webui/favicon_source.h b/chrome/browser/ui/webui/favicon_source.h

index b1faf72144ddafeb1a1efd093c4fbf9c5135251e..2e837861283b1fd10a4b1999bf94d92ab7d5b815 100644

--- a/chrome/browser/ui/webui/favicon_source.h

+++ b/chrome/browser/ui/webui/favicon_source.h

@@ -119,7 +119,7 @@ class FaviconSource : public content::URLDataSource {

// Parses |raw_path|, which should be in the format described at the top of

// the file. Returns true if |raw_path| could be parsed.

sreeram 2013/06/04 22:01:56 Change "raw_path" to "path" in both lines above.

pedro (no code reviews) 2013/06/07 23:34:21 Done.

- bool ParsePath(const std::string& raw_path,

+ bool ParsePath(const std::string& path,

bool* is_icon_url,

GURL* url,

int* size_in_dip,