Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3768)

Unified Diff: chrome/renderer/searchbox/searchbox.h

Issue 15388002: Supporting high dpi favicons in Instant Extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing Samarth's comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox.h
diff --git a/chrome/renderer/searchbox/searchbox.h b/chrome/renderer/searchbox/searchbox.h
index 0a45a051163f8c9995779097ae65609ec2434729..616a956112a8ebcf38de21275d715c7847b3a4ee 100644
--- a/chrome/renderer/searchbox/searchbox.h
+++ b/chrome/renderer/searchbox/searchbox.h
@@ -127,11 +127,13 @@ class SearchBox : public content::RenderViewObserver,
// Generates the favicon URL of the most visited item specified by the
// |transient_url|. If the |transient_url| is valid, returns true and fills in
- // |url|. If the |transient_url| is invalid, returns false and |url| is not
- // set.
+ // |url|. If the |transient_url| is invalid, returns true and |url| is set to
+ // "chrome-search://favicon/" in order to prevent the invalid URL to be
+ // requested.
//
- // Valid form of |transient_url|:
- // chrome-search://favicon/<render_view_id>/<most_visited_item_id>
+ // Valid forms of |transient_url|:
+ // chrome-search://favicon/<view_id>/<restricted_id>
+ // chrome-search://favicon/<favicon_parameters>/<view_id>/<restricted_id>
bool GenerateFaviconURLFromTransientURL(const GURL& transient_url,
GURL* url) const;

Powered by Google App Engine
This is Rietveld 408576698