Supporting high dpi favicons in Instant Extended.

chrome/renderer/resources/extensions/searchbox_api.js

Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index c17ae98d9ecec8bd22b67b09a0b484e8293e7a6f..a44b43450d9c0a29572adcc9a9a38e01dc11c4e2 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -257,6 +257,7 @@ if (!chrome.embeddedSearch) {
       function GetMostVisitedItemsWrapper() {
         var mostVisitedItems = GetMostVisitedItems();
         for (var i = 0, item; item = mostVisitedItems[i]; ++i) {
+          item.faviconUrl = UpdateFaviconUrl(item.faviconUrl);
           // These properties are private data and should not be returned to
           // the page. They are only accessible via getMostVisitedItemData().
           item.url = null;
@@ -267,6 +268,15 @@ if (!chrome.embeddedSearch) {
         return mostVisitedItems;
       }
 
+      function UpdateFaviconUrl(faviconUrl) {

[samarth, 2013/06/14 21:54:46]

Don't try to parse this URL in javascript.  Instead, just pass in the relevant
fields (rendererId, mostVisitedId) and construct the URL here.

[pedro (no code reviews), 2013/06/18 22:35:13]

Done.

+        var chromeSearchFaviconHost = "chrome-search://favicon/";
+        if (faviconUrl.indexOf(chromeSearchFaviconHost) == 0) {
+          return chromeSearchFaviconHost + "size/16@" +
+              window.devicePixelRatio + "x/" +
+              faviconUrl.replace(chromeSearchFaviconHost, '');
+        }
+      }
+
       // =======================================================================
       //                           Exported functions
       // =======================================================================